All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: shao.mingyin@zte.com.cn
Cc: dlemoal@kernel.org, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_dwc: reject invalid device tree port numbers
Date: Mon, 9 Nov 2026 20:47:43 +0100	[thread overview]
Message-ID: <avIjXxp3hu7xd_s9@ryzen> (raw)
In-Reply-To: <20261110000234827nXRPQjzsInWFXaAaxeF6N@zte.com.cn>

On Tue, Nov 10, 2026 at 12:02:34AM +0800, shao.mingyin@zte.com.cn wrote:
> On Mon, Nov 09, 2026 at 04:19:56PM +0100, Niklas Cassel wrote:
> > Again, this warning is reduntant, as it is already printed by
> > ahci_platform_get_resources().
> 
> Agreed, and thanks.  The KASAN run for this patch printed "invalid port
> number 100" twice in a row, which is exactly the duplication you point
> out; dropping the warning leaves only the skip, which is what the test
> exercises.
> 
> > And please send this as a patch 2/2 with the libahci_platform patch as a
> > patch 1/2.
> 
> Will do: 1/2 libahci_platform, 2/2 this one.  Since the code changes I
> won't carry Damien's v1 Reviewed-by over; he is Cc'd.

I think it is okay to keep his tag, since the only change is a dropped
warning.


Kind regards,
Niklas

  reply	other threads:[~2026-11-09 19:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 14:13 [PATCH] ata: ahci_dwc: reject invalid device tree port numbers shao.mingyin
2026-11-05  3:05 ` Damien Le Moal
2026-11-09 15:19 ` Niklas Cassel
2026-11-09 16:02   ` shao.mingyin
2026-11-09 19:47     ` Niklas Cassel [this message]
2026-11-10  2:07       ` shao.mingyin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avIjXxp3hu7xd_s9@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shao.mingyin@zte.com.cn \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.