From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, raoxu <raoxu@uniontech.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] zram: Avoid duplicate slots in batched writeback
Date: Tue, 10 Nov 2026 15:40:13 +0900 [thread overview]
Message-ID: <avK6Y1VmIYIBrorl@google.com> (raw)
In-Reply-To: <F24EF6333964B482+20261110061830.272091-1-raoxu@uniontech.com>
On (26/11/10 14:18), raoxu wrote:
> The writeback interface accepts multiple page_index and page_indexes
> parameters in one operation. Their ranges can overlap, but
> scan_slots_for_writeback() only excludes slots that are already being
> written back or marked as same-filled.
>
> A slot selected by an earlier range is placed on the post-processing list
> and marked with ZRAM_PP_SLOT. Without checking that flag, an overlapping
> range can enqueue the same slot again and submit it for writeback more
> than once.
>
> Skip slots already marked ZRAM_PP_SLOT while holding the slot lock. This
> keeps each slot in a writeback scan session represented by at most one
> post-processing entry and leaves the existing release and reuse paths
> unchanged.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
LGTM.
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Jens, do you want to pick it up and route via block tree or should
we route via "more traditional" tree (Andrew's tree)?
prev parent reply other threads:[~2026-11-10 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 6:18 [PATCH] zram: Avoid duplicate slots in batched writeback raoxu
2026-11-10 6:40 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avK6Y1VmIYIBrorl@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=raoxu@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.