Re: [PATCH v15 03/35] firmware: arm_scmi: Introduce a dedicated SCMI Errors header

[Cristian Marussi <cristian.marussi@arm.com>]

On Mon, Nov 09, 2026 at 02:01:29PM -0800, Jonathan Cameron wrote:
> On Mon,  9 Nov 2026 09:11:49 +0000
> Cristian Marussi <cristian.marussi@arm.com> wrote:
> 
> > Add a new dedicated header and move all of the errors definitions and
> > mapping helpers into it and out of common.h so that SCMI errors definitions
> > alone can be easily included in protocol files without all of the unrelated
> > additional stuff contained in common.h
> 
> In ideal world I'd move first and add the new codes later.
> (so swap this and previous patch).
> 

Ok but logically the new separated header is needed by the fact that the
new added error codes has to be checked in-protocol and including
common.h in protocol unit bring in a lot of unneeded stuff.

> Trivial thing but reduce the patch size a tiny bit!
> 
> Other than that, seems like there are enough of these
> for a separate header to perhaps make sense.
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

Thanks,
Cristian