From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] soundwire: Improve channel min/max comments
Date: Tue, 10 Nov 2026 09:39:51 +0000 [thread overview]
Message-ID: <avLmZ64jIfSy6Kl8@opensource.cirrus.com> (raw)
In-Reply-To: <42f25327-cb1e-4e16-a302-b9d367f30087@linux.dev>
On Tue, Nov 10, 2026 at 09:29:00AM +0100, Pierre-Louis Bossart wrote:
> On 11/9/26 18:38, Charles Keepax wrote:
> > Presently, the comments for the minimum and maximum channels are
> > misleading. In the SDCA specification these are actually channel
> > indexes not a count of the number of channels. So for example
> > min_ch=4 and max_ch=5 means that 1 or 2 channels are supported.
> > Update the comments associated with the structure to make this
> > more clear.
>
> It's the DisCo spec, not SDCA.
Ooops yeah thank you, I will fix.
> > + * @max_ch: Index of the maximum channel supported
> > + * @min_ch: Index of the minimum channel supported
>
> that's also ambiguous.
>
> Maybe just use the spec definition "minimum Channel Number of this Audio
> Port"
Yeah I am happy with that wording will update for the spin.
Thanks,
Charles
next prev parent reply other threads:[~2026-11-10 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 17:38 [PATCH 0/2] Update handling of min and max channel in DisCo Charles Keepax
2026-11-09 17:38 ` [PATCH 1/2] soundwire: Improve channel min/max comments Charles Keepax
2026-11-10 8:29 ` Pierre-Louis Bossart
2026-11-10 9:39 ` Charles Keepax [this message]
2026-11-09 17:38 ` [PATCH 2/2] soundwire: Assume default maximum valid channel if not specified Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avLmZ64jIfSy6Kl8@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.