Re: [PATCH net-next v2 7/7] net: ethernet: adi: adin1110: Add OA TC6 protocol support for ADIN1110

["Alvin Šipraga" <alvin.sipraga@analog.com>]

On Tue, Nov 10, 2026 at 09:02:26AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] net: adin1110: NULL netdev_ops dereference in
>   adin1110_oa_tc6_probe()
> --
> 
> commit a8946759404622a473f14b5de5bca9f8c82eea9c
> Author: Ciprian Regus <ciprian.regus@analog.com>
> 
> net: ethernet: adi: adin1110: Add OA TC6 protocol support for ADIN1110
> 
> This commit adds OPEN Alliance TC6 SPI protocol support for the ADIN1110
> using the oa_tc6 framework when the adi,spi-oa-tc6 property is present.
> 

[...]

> > +
> > +	netdev->if_port = IF_PORT_10BASET;
> > +	netdev->netdev_ops = &adin1110_tc6_netdev_ops;
> 
> [Severity: High]
> Does calling oa_tc6_init() before setting netdev->netdev_ops cause a NULL
> pointer dereference when CONFIG_NET_SHAPER is enabled?
> 
> oa_tc6_init() calls oa_tc6_phy_init() -> phy_connect_direct() ->
> phy_attach_direct() -> phy_link_topo_add_phy() -> netdev_need_ops_lock(),
> which dereferences dev->netdev_ops->net_shaper_ops while netdev->netdev_ops
> is still NULL.

If this report is legit, then it looks like adin1140.c has the same
problem. Just FYI.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261109085952.105331-1-iustin.stolniceanu@analog.com?part=7