From: Cristian Marussi <cristian.marussi@arm.com>
To: "Clément Le Goffic" <clegoffic@baylibre.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Linus Walleij <linusw@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Oleksii Moisieiev <oleksii_moisieiev@epam.com>,
Andy Shevchenko <andy@kernel.org>, Dhruva Gole <d-gole@ti.com>,
Bartosz Golaszewski <brgl@kernel.org>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/11] pinctrl: scmi: report an off setting as not set
Date: Tue, 10 Nov 2026 15:35:08 +0000 [thread overview]
Message-ID: <avM5rBHedZDn45kc@pluto> (raw)
In-Reply-To: <7f613b00-bafa-4f4d-889b-4e37f5009b6f@baylibre.com>
On Tue, Nov 10, 2026 at 03:47:33PM +0100, Clément Le Goffic wrote:
> Hi Cristian,
>
> On 11/10/26 12:24 PM, Cristian Marussi wrote:
> > On Fri, Oct 30, 2026 at 04:58:35PM +0100, Clément Le Goffic wrote:
> >> A get of a setting that is on or off, the flags and the pulls, returned
> >> 0 as a value, so every one of them showed as set on every pin. Return
> >> -EINVAL when the platform answers 0, which is how pinconf reports a
> >> setting that is not active.
> >>
> >> Fixes: eb524cb651b7 ("pinctrl: Implementation of the generic scmi-pinctrl driver")
> >> Signed-off-by: Clément Le Goffic <clegoffic@baylibre.com>
> >> ---
> >
> > LGTM.
> > Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>
> I'll apply Andy remarks. Can I keep your Reviewed-by with those fixes?
Sure.
Cristian
next prev parent reply other threads:[~2026-11-10 15:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 15:58 [PATCH 00/11] pinctrl: scmi: fixes and GPIO function support Clément Le Goffic
2026-10-30 15:58 ` [PATCH 01/11] pinctrl: scmi: send the drive strength in microamperes Clément Le Goffic
2026-11-10 11:01 ` Cristian Marussi
2026-10-30 15:58 ` [PATCH 02/11] pinctrl: scmi: map the schmitt trigger enable to its SCMI type Clément Le Goffic
2026-11-10 11:04 ` Cristian Marussi
2026-10-30 15:58 ` [PATCH 03/11] pinctrl: scmi: send the settings without argument as enabled Clément Le Goffic
2026-11-10 11:05 ` Cristian Marussi
2026-10-30 15:58 ` [PATCH 04/11] pinctrl: scmi: report an off setting as not set Clément Le Goffic
2026-10-30 16:09 ` sashiko-bot
2026-11-03 11:38 ` Andy Shevchenko
2026-11-04 9:32 ` Clément Le Goffic
2026-11-10 11:24 ` Cristian Marussi
2026-11-10 14:47 ` Clément Le Goffic
2026-11-10 15:35 ` Cristian Marussi [this message]
2026-10-30 15:58 ` [PATCH 05/11] firmware: arm_scmi: stop reading past PINCTRL_LIST_ASSOCIATIONS replies Clément Le Goffic
2026-11-10 10:27 ` Cristian Marussi
2026-11-10 14:44 ` Clément Le Goffic
2026-10-30 15:58 ` [PATCH 06/11] firmware: arm_scmi: report the pin-only and GPIO flags of functions Clément Le Goffic
2026-10-30 15:58 ` [PATCH 07/11] pinctrl: scmi: give no groups to pin-only functions Clément Le Goffic
2026-11-10 11:48 ` Cristian Marussi
2026-10-30 15:58 ` [PATCH 08/11] pinctrl: scmi: mark the GPIO functions Clément Le Goffic
2026-11-10 13:16 ` Cristian Marussi
2026-11-12 16:15 ` Bartosz Golaszewski
2026-10-30 15:58 ` [PATCH 09/11] pinctrl: scmi: report whether a function is GPIO Clément Le Goffic
2026-11-12 16:15 ` Bartosz Golaszewski
2026-10-30 15:58 ` [PATCH 10/11] firmware: arm_scmi: add an operation to set the function of a single pin Clément Le Goffic
2026-11-10 13:20 ` Cristian Marussi
2026-10-30 15:58 ` [PATCH 11/11] pinctrl: scmi: select the GPIO function on GPIO requests Clément Le Goffic
2026-11-03 11:41 ` Andy Shevchenko
2026-11-04 9:38 ` Clément Le Goffic
2026-11-04 10:55 ` Andy Shevchenko
2026-11-05 12:58 ` Clément Le Goffic
2026-11-10 13:49 ` Cristian Marussi
2026-11-10 14:09 ` Andy Shevchenko
2026-11-10 14:45 ` Clément Le Goffic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avM5rBHedZDn45kc@pluto \
--to=cristian.marussi@arm.com \
--cc=andy@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=brgl@kernel.org \
--cc=clegoffic@baylibre.com \
--cc=d-gole@ti.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksii_moisieiev@epam.com \
--cc=peng.fan@nxp.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.