From: Petr Mladek <pmladek@suse.com>
To: Song Liu <song@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
joe.lawrence@redhat.com, shuah@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/12] klp-build: Fix dependent patches, add selftests
Date: Tue, 10 Nov 2026 13:45:30 +0100 [thread overview]
Message-ID: <avMR6tKwddVBrkpk@pathway.suse.cz> (raw)
In-Reply-To: <20261028214534.1919398-1-song@kernel.org>
On Wed 2026-10-28 14:45:22, Song Liu wrote:
> klp-build fails when a later patch in the series depends on an earlier
> one, because it fixes each patch against the original source on its
> own. Patch 1 fixes this by combining the patches into a single patch
> before adding the #line directives.
>
> scripts/livepatch/Makefile | 3 +-
> scripts/livepatch/klp-build | 137 +--------
> scripts/livepatch/klp-prepare-patch | 277 ++++++++++++++++++
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/livepatch/README | 16 +
> .../livepatch/test_klp_build/Makefile | 26 ++
> .../livepatch/test_klp_build/functions.sh | 149 ++++++++++
> .../livepatch/test_klp_build/run-tests.sh | 68 +++++
> .../livepatch/test_klp_build/test-basic.sh | 93 ++++++
> .../test_klp_build/test-cancelling-patches.sh | 102 +++++++
> .../test-independent-patches.sh | 124 ++++++++
> .../test_klp_build/test-line-directives.sh | 175 +++++++++++
> .../test-new-and-deleted-files.sh | 94 ++++++
> .../test_klp_build/test-offset-and-fuzz.sh | 120 ++++++++
> .../test_klp_build/test-patch-not-applying.sh | 73 +++++
> .../test_klp_build/test-unsupported-files.sh | 30 ++
> 16 files changed, 1366 insertions(+), 122 deletions(-)
> create mode 100755 scripts/livepatch/klp-prepare-patch
> create mode 100644 tools/testing/selftests/livepatch/test_klp_build/Makefile
> create mode 100644 tools/testing/selftests/livepatch/test_klp_build/functions.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/run-tests.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-basic.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-cancelling-patches.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-independent-patches.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-line-directives.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-new-and-deleted-files.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-offset-and-fuzz.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-patch-not-applying.sh
> create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-unsupported-files.sh
I am sorry, I am overloaded and do not have time for a proper review.
I just see that it adds a lot of new files. And I wonder how much it
shares with the livepatch selftests. Would it make sense to put
it into a separate directory, e.g. tools/testing/selftests/klp-build ?
Best Regards,
Petr
next prev parent reply other threads:[~2026-11-10 12:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 21:45 [PATCH v2 00/12] klp-build: Fix dependent patches, add selftests Song Liu
2026-10-28 21:45 ` [PATCH v2 01/12] klp-build: Fix dependent patches in a series Song Liu
2026-10-28 21:45 ` [PATCH v2 02/12] klp-build: Process the patches before building the original kernel Song Liu
2026-10-28 21:45 ` [PATCH v2 03/12] klp-build: Move patch processing to klp-prepare-patch Song Liu
2026-11-10 19:55 ` Josh Poimboeuf
2026-10-28 21:45 ` [PATCH v2 04/12] selftests/livepatch: Add tests for klp-prepare-patch Song Liu
2026-10-28 21:45 ` [PATCH v2 05/12] selftests/livepatch: Test klp-prepare-patch with dependent patches Song Liu
2026-10-28 21:45 ` [PATCH v2 06/12] selftests/livepatch: Test klp-prepare-patch with independent patches Song Liu
2026-10-28 21:45 ` [PATCH v2 07/12] selftests/livepatch: Test klp-prepare-patch with patches which cancel out Song Liu
2026-10-28 21:45 ` [PATCH v2 08/12] selftests/livepatch: Test klp-prepare-patch with created and deleted files Song Liu
2026-10-28 21:45 ` [PATCH v2 09/12] selftests/livepatch: Test where klp-prepare-patch adds #line directives Song Liu
2026-10-28 21:45 ` [PATCH v2 10/12] selftests/livepatch: Test klp-prepare-patch with unsupported files Song Liu
2026-10-28 21:45 ` [PATCH v2 11/12] selftests/livepatch: Test klp-prepare-patch with patches which don't apply Song Liu
2026-10-28 21:45 ` [PATCH v2 12/12] selftests/livepatch: Test klp-prepare-patch with offset and fuzz Song Liu
2026-11-10 12:45 ` Petr Mladek [this message]
2026-11-11 3:58 ` [PATCH v2 00/12] klp-build: Fix dependent patches, add selftests Song Liu
2026-11-12 13:31 ` Petr Mladek
2026-11-11 0:42 ` Dylan Hatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMR6tKwddVBrkpk@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.