From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: JiangJieHua <jiangjiehua1@huawei.com>,
Paul Moore <paul@paul-moore.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Paris <eparis@redhat.com>,
Ricardo Robaina <rrobaina@redhat.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
zhangchangzhong@huawei.com
Subject: Re: [PATCH] audit: fix incomplete NETFILTER_PKT records and return void
Date: Tue, 10 Nov 2026 14:39:06 +0100 [thread overview]
Message-ID: <avMeegglB__27xqp@strlen.de> (raw)
In-Reply-To: <avMXzjF9hIcTVc9c@chamomile>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > + goto unknown_proto;
> > + if (ih->version != 4 || ih->ihl < 5)
> > + goto unknown_proto;
> > +
> > + thoff = skb_network_offset(skb) + ih->ihl * 4;
> > + frag = ntohs(ih->frag_off) & IP_OFFSET;
>
> Are we going to add all these validations everywhere in the code?
>
> So we will have to validate that the IPv4 header is well-formed over
> and over again?
Bridge doesn't check/validate ip headers.
I agree it would be best to have a central helper for this, this
copypastry has gotten out of hand.
next prev parent reply other threads:[~2026-11-10 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 12:29 [PATCH] audit: fix incomplete NETFILTER_PKT records and return void JiangJieHua
2026-11-10 11:38 ` sashiko-bot
2026-11-10 13:10 ` Pablo Neira Ayuso
2026-11-10 13:39 ` Florian Westphal [this message]
2026-11-10 15:51 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMeegglB__27xqp@strlen.de \
--to=fw@strlen.de \
--cc=audit@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=eparis@redhat.com \
--cc=jiangjiehua1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rrobaina@redhat.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.