From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D16E606A31C for ; Tue, 10 Nov 2026 14:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WI1iaJ+l Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xQn48-0004FZ-Ez; Tue, 10 Nov 2026 09:43:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xQn44-00047H-NI for qemu-devel@nongnu.org; Tue, 10 Nov 2026 09:43:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xQn42-0006HJ-Ia for qemu-devel@nongnu.org; Tue, 10 Nov 2026 09:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794321789; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aZgaIkN2jOMqPste+JBv9Jq7of9x9LVwvQZXzeFCPXI=; b=WI1iaJ+l/y1pz59wtM+TeV20GA0tQ9nQbdsLQfYQDbtHkgZKl70JrInfSCM9kF3zSKnJFo zWlX/x4O1LBvMWdAoZyqIDwvBTWH/cNOzoMxtN/I/QuCDapUV2W8wmJJqwE3EhRjk4lRVc QgNz4mvZG5u61ZTeHYfbGZpjYV7hlx0= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-5qmCQugnNPqP9Xy0II2K8A-1; Tue, 10 Nov 2026 09:43:05 -0500 X-MC-Unique: 5qmCQugnNPqP9Xy0II2K8A-1 X-Mimecast-MFC-AGG-ID: 5qmCQugnNPqP9Xy0II2K8A_1794321784 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4E66518005BF for ; Tue, 10 Nov 2026 14:43:04 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DDC819634EC; Tue, 10 Nov 2026 14:43:03 +0000 (UTC) Date: Tue, 10 Nov 2026 14:43:00 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] ui/dbus: validate clipboard selection in Release handler Message-ID: References: <20261019092351.2435194-2-marcandre.lureau@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261019092351.2435194-2-marcandre.lureau@redhat.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Oct 19, 2026 at 01:23:51PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > The clipboard "Release" D-Bus method handler passes the caller provided > selection to qemu_clipboard_peer_release() without any bounds check, > unlike the "Grab" and "Request" handlers. > > An out-of-range selection reaches qemu_clipboard_info(), which asserts > selection < QEMU_CLIPBOARD_SELECTION__COUNT and aborts QEMU (with > asserts compiled out, it would index the cbinfo[] array out of bounds). > > Reject invalid selections with an error, following the same pattern as > the other clipboard handlers. > > Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4717 > Signed-off-by: Marc-André Lureau > --- > ui/dbus-clipboard.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) If you remove the text about "with asserts compiled out..." as Peter suggested, then Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|