From: Cristian Marussi <cristian.marussi@arm.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
imx@lists.linux.dev, Peng Fan <peng.fan@nxp.com>,
linux-amarula@amarulasolutions.com, arm-scmi@vger.kernel.org,
michael@amarulasolutions.com,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 2/2] clk: scmi: reject SSC configuration out of the OEM field range
Date: Tue, 10 Nov 2026 14:43:15 +0000 [thread overview]
Message-ID: <avMtgxmGXTbTKG1t@pluto> (raw)
In-Reply-To: <20261104103620.4054694-3-dario.binacchi@amarulasolutions.com>
On Wed, Nov 04, 2026 at 11:36:03AM +0100, Dario Binacchi wrote:
> The i.MX SCMI OEM extension stores the spread in an 8-bit field, in
> tenths of a percent, and the modulation frequency in a 16-bit field.
>
> FIELD_PREP() silently truncates values that do not fit in the target
> field. Moreover, the conversion from permyriad to tenths of a percent
> turns values below 10 permyriad into zero, which is then passed to the
> firmware as no spread at all.
>
> Reject these cases with a warning instead of silently programming a
> configuration different from the requested one.
>
> A request with no spread method disables SSC, so send a zeroed
> configuration to the firmware in that case, without checking the
> spread and the modulation frequency, which are meaningless then.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
LGTM.
From: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
prev parent reply other threads:[~2026-11-10 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 10:36 [PATCH v15 0/2] clk: scmi: fix the i.MX OEM spread spectrum configuration Dario Binacchi
2026-11-04 10:36 ` [PATCH v15 1/2] clk: scmi: fix SSC spread conversion Dario Binacchi
2026-11-10 14:21 ` Cristian Marussi
2026-11-04 10:36 ` [PATCH v15 2/2] clk: scmi: reject SSC configuration out of the OEM field range Dario Binacchi
2026-11-10 14:43 ` Cristian Marussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMtgxmGXTbTKG1t@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.