From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY
Date: Tue, 10 Nov 2026 17:40:22 +0100 [thread overview]
Message-ID: <avNI9rHN3GS7Kmlz@pks.im> (raw)
In-Reply-To: <xmqqse18u0jw.fsf@gitster.g>
On Tue, Nov 10, 2026 at 08:13:39AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > All I'm pointing out is that there are cases where we could be as
> > defensive as everywhere else if we started passing down the options to
> > calling contexts that don't have it yet.
>
> OK, that does make sense, but I suspect the current helper functions
> that do not get unpack_opt do not because they do not have a reason
> to access anything in it. We could throw "struct repository *" into
> that struct and use that one (ignoring the one in the istates).
>
> I however think that would be a separate clean-up.
Yup, that's reasonable. Thanks!
Patrick
next prev parent reply other threads:[~2026-11-10 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 1:26 [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY Junio C Hamano
2026-11-07 1:29 ` [PATCH 2/2] unpack-trees: consistently use "struct index_state *istate" Junio C Hamano
2026-11-09 13:46 ` Derrick Stolee
2026-11-09 13:41 ` [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY Patrick Steinhardt
2026-11-09 19:30 ` Junio C Hamano
2026-11-10 7:04 ` Patrick Steinhardt
2026-11-10 16:13 ` Junio C Hamano
2026-11-10 16:40 ` Patrick Steinhardt [this message]
2026-11-09 13:45 ` Derrick Stolee
2026-11-09 20:54 ` [PATCH v2 0/2] unpack-trees.c w/o the_repository Junio C Hamano
2026-11-09 20:54 ` [PATCH v2 1/2] unpack-trees: lose USE_THE_REPOSITORY Junio C Hamano
2026-11-09 20:54 ` [PATCH v2 2/2] unpack-trees: consistently use "struct index_state *istate" Junio C Hamano
2026-11-10 13:22 ` [PATCH v2 0/2] unpack-trees.c w/o the_repository Derrick Stolee
2026-11-10 17:28 ` Junio C Hamano
2026-11-11 12:48 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avNI9rHN3GS7Kmlz@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.