From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Andrii Pasichnyk <apasichnik9@gmail.com>
Cc: netdev@vger.kernel.org, wireguard@lists.zx2c4.com,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] wireguard: peer: free packets left on the per-peer queues on removal
Date: Tue, 10 Nov 2026 17:37:31 +0100 [thread overview]
Message-ID: <avNIS67grg_Qc5Vy@zx2c4.com> (raw)
In-Reply-To: <20261003201625.4572-1-apasichnik9@gmail.com>
On Sat, Oct 03, 2026 at 11:16:25PM +0300, Andrii Pasichnyk wrote:
> Reproduced with the WireGuard selftest VM (x86 KVM, 1 vCPU, net-next):
> remove a peer while a UDP flood keeps its receive queue busy, re-add it,
> repeat, then run the selftest's created/destroyed object check. Over
> 2140 removals the unpatched kernel leaked a peer and its keypair 5
> times ("wg0: Peer 27: merely created"); with this patch, 0 times in
> another 2140.
I'd be interested in seeing your adjustment to netns.sh so that I can
test this myself and validate various approaches. Do you have something
really minimal? Also, is this a test case that could be implemented
minimally enough that we could integrate this into netns.sh permanently?
next prev parent reply other threads:[~2026-11-10 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 20:16 [PATCH net] wireguard: peer: free packets left on the per-peer queues on removal Andrii Pasichnyk
2026-10-03 20:19 ` netdev-bot+sinfo
2026-10-03 20:41 ` Andrii Pasichnyk
2026-10-23 21:16 ` pasichdev
2026-10-23 22:58 ` Jason A. Donenfeld
2026-11-10 16:37 ` Jason A. Donenfeld [this message]
2026-11-10 18:00 ` Andrii Pasichnyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avNIS67grg_Qc5Vy@zx2c4.com \
--to=jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=apasichnik9@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.