From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Arun Iyengar <aiyengar1990@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: slave-eeprom: Add an OF match table for module autoload
Date: Tue, 10 Nov 2026 19:15:58 +0100 [thread overview]
Message-ID: <avNe7fvRYxzM8DBe@monoceros> (raw)
In-Reply-To: <20261110-i2c-slave-eeprom-of-match-v1-1-8f762bf06205@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hello,
On Tue, Nov 10, 2026 at 05:34:54AM +0000, Arun Iyengar wrote:
> diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
> index 226d722af662..a08abd895412 100644
> --- a/drivers/i2c/i2c-slave-eeprom.c
> +++ b/drivers/i2c/i2c-slave-eeprom.c
> @@ -20,6 +20,7 @@
> #include <linux/firmware.h>
> #include <linux/i2c.h>
> #include <linux/init.h>
> +#include <linux/mod_devicetable.h>
Please don't add that include. <linux/i2c.h> already provides
of_device_id without introducing useless build dependencies.
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/slab.h>
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-10 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 5:34 [PATCH] i2c: slave-eeprom: Add an OF match table for module autoload Arun Iyengar
2026-11-10 5:34 ` Arun Iyengar via B4 Relay
2026-11-10 18:15 ` Uwe Kleine-König [this message]
2026-11-11 10:00 ` Wolfram Sang
2026-11-12 8:02 ` Arun Iyengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avNe7fvRYxzM8DBe@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=aiyengar1990@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.