Re: [PATCH v6 2/2] iio: temperature: add support for Analog Devices MAX30210

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Nov 10, 2026 at 10:53:23PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 10, 2026 at 10:14:42AM +0800, John Erasmus Mari Geronimo wrote:

...

> > +static int max30210_write_raw(struct iio_dev *indio_dev,
> > +			      struct iio_chan_spec const *chan,
> > +			      int val, int val2, long mask)
> > +{
> > +	struct max30210_state *st = iio_priv(indio_dev);
> > +
> > +	switch (mask) {
> > +	case IIO_CHAN_INFO_SAMP_FREQ: {
> 
> 		struct regmap *map = st->regmap;
> 
> > +		if (val < 0 || val2 < 0)
> > +			return -EINVAL;
> > +
> > +		IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim);
> > +		if (IIO_DEV_ACQUIRE_FAILED(claim))
> > +			return -EBUSY;
> > +
> > +		for (unsigned int i = 0; i < ARRAY_SIZE(max30210_samp_freq_avail); i++) {
> 
> 			unsigned int mask = MAX30210_TEMPCONF2_TEMP_PERIOD_MASK;
> 			unsigned int value = field_prep(mask, i);

Ah, there is a conflict with above 'mask'. Something like 'm' and 'v'
would fit?

> > +			if (val != max30210_samp_freq_avail[i][0] ||
> > +			    val2 != max30210_samp_freq_avail[i][1])
> > +				continue;
> > +
> > +			return regmap_update_bits(st->regmap, MAX30210_TEMP_CONF_2_REG,
> > +					MAX30210_TEMPCONF2_TEMP_PERIOD_MASK,
> > +					FIELD_PREP(MAX30210_TEMPCONF2_TEMP_PERIOD_MASK, i));
> 
> 			return regmap_update_bits(map, MAX30210_TEMP_CONF_2_REG,
> 						  mask, value);
> 
> > +		}
> > +
> > +		return -EINVAL;
> > +	}
> > +	default:
> > +		return -EINVAL;
> > +	}
> > +}

-- 
With Best Regards,
Andy Shevchenko