Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages()

[Yeoreum Yun <yeoreum.yun@arm.com>]

On Tue, Nov 10, 2026 at 11:35:25PM +0100, David Hildenbrand (Arm) wrote:
> On 11/10/26 22:27, Yeoreum Yun wrote:
> > On Tue, Nov 10, 2026 at 03:23:15PM -0500, Rik van Riel wrote:
> >> On Tue, 2026-11-10 at 20:19 +0000, Yeoreum Yun wrote:
> >>>
> >>> Hmm, Wouldn't this name be semantically much the same as keeping
> >>> the existing gup_unshared_page(), since both essentially convey that
> >>> no unsharing is required from GUP's perspective?
> >>
> >> The function measures how many pages in
> >> this current interval do not need to be
> >> unshared.
> >>
> >> I'm happy with any name, though.
> >>
> >> I would really like to just see this
> >> code go in, so I can post my two
> >> GUP series on top, first the batching
> >> for the GUP-slow path, and then the
> >> series that allows access_remote_vm()
> >> and friends to work under the per-VMA
> >> lock.
> > 
> > @David, If you don't have any strong comments for original name
> > -- gup_unshared_page(), May I post next version with resolving other
> > comments so that Rik's series be posted soon?
> > 
> > Otherewise, gup_skip_unshare_pages() works for me.
> 
> Let me think ...
> 
> Maybe just throw in:
> 
> 	gup_pages_not_requiring_unshare

Agree. though name is long, it would be better to explain anyway.

Thanks!


-- 
Sincerely,
Yeoreum Yun