From: Hangbin Liu <hangbin.liu@linux.dev>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@kernel.org
Subject: Re: [PATCH net v2 0/3] rtnetlink: fix truncation of dump entry
Date: Wed, 11 Nov 2026 10:23:53 +0800 [thread overview]
Message-ID: <avPRuQugknhA-HqL@fedora> (raw)
In-Reply-To: <20261110172925.3293312-1-stephen@networkplumber.org>
On Tue, Nov 10, 2026 at 09:26:15AM -0800, Stephen Hemminger wrote:
> While analyzing one of the OSS Scanner dump reports for iproute2,
> a bug was uncovered in netlink route dump.
> A route dump whose first entry is too large for the dump skb ends with
> NLMSG_DONE and status 0. The route and everything after it is silently
> dropped; "ip route show table 100" prints nothing and exits 0.
>
> It takes some non real world stuff to do this
> like a 500 way multipath route is enough to trigger this.
>
> The series is broken into three parts:
> 1. Fix regression in rtnl_dumpit().
> Do not hide EMSGSIZE on empty skb case.
> 2. Fix IPv6 FIB dump to propagate error properly
> 3. Add a test for this bug.
>
> v2 - drop Assisted-by
> - correct commit message about "ip route get"
>
> Stephen Hemminger (3):
> rtnetlink: return EMSGSIZE when first dump entry does not fit
> ipv6: return EMSGSIZE when first route in dump does not fit
> selftests: net: netlink-dumps: test dump of route larger than skb
>
> net/core/rtnetlink.c | 5 +-
> net/ipv6/ip6_fib.c | 6 +
> tools/testing/selftests/net/config | 3 +
> tools/testing/selftests/net/netlink-dumps.c | 271 +++++++++++++++++++-
> 4 files changed, 280 insertions(+), 5 deletions(-)
>
> --
> 2.53.0
>
For the series
Tested-by: Hangbin Liu <liuhangbin@kylinos.cn>
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
prev parent reply other threads:[~2026-11-11 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 17:26 [PATCH net v2 0/3] rtnetlink: fix truncation of dump entry Stephen Hemminger
2026-11-10 17:26 ` [PATCH net v2 1/3] rtnetlink: return EMSGSIZE when first dump entry does not fit Stephen Hemminger
2026-11-12 5:27 ` netdev-bot+sashiko
2026-11-12 15:31 ` Ido Schimmel
2026-11-10 17:26 ` [PATCH net v2 2/3] ipv6: return EMSGSIZE when first route in dump " Stephen Hemminger
2026-11-12 15:31 ` Ido Schimmel
2026-11-12 16:17 ` Stephen Hemminger
2026-11-10 17:26 ` [PATCH net v2 3/3] selftests: net: netlink-dumps: test dump of route larger than skb Stephen Hemminger
2026-11-12 5:27 ` netdev-bot+sashiko
2026-11-11 2:23 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avPRuQugknhA-HqL@fedora \
--to=hangbin.liu@linux.dev \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.