Re: [PATCH v2 for-11.2] docs/devel/testing: iotests check script should be run via 'run'

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Nov 06, 2026 at 01:55:39PM -0600, Eric Blake wrote:
> On Fri, Nov 06, 2026 at 05:01:57PM +0000, Peter Maydell wrote:
> > The iotests section of the testing documentation suggests directly
> > running the "./check" script.  However if you do this then the
> > script complains:
> > 
> > WARNING: iotests is being run from outside of the configure-time python virtual environment
> > [...]
> > Please use the meson run script:
> >         /home/pm215/qemu/build/x86-tgt-san-dbg/run ./check
> 
> Huh. I did a git checkout, mkdir build, cd build && ../configure, then:
> 
> $ build/run tests/qemu-iotests/check 5
> 
> WARNING: iotests is being run from outside of the configure-time python virtual environment
> 
> current python: /home/eblake/qemu/build/pyvenv/bin/python3
> pyvenv python:  /home/pyvenv/bin/python3
> ...

Beyond that warning, the 'check' script has bad heuristics for
finding the build directory, looking for 'cwd' in this particular
case which is wrong. I've sent a path that addresses this which
does the job in my testing at least.

> but running directly from the configured directory:
> 
> $ cd build
> $ ./run tets/qemu-iotests/check 5
> 
> does what this patch recommends.
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|