Re: [PATCH 1/2] common/zoned: allow setting the zloop device capacity and extra parameters

[Carlos Maiolino <cem@kernel.org>]

On Mon, Nov 09, 2026 at 06:51:45PM +0100, Johannes Thumshirn wrote:
> Add optional fourth and fifth arguments to _create_zloop() so tests can
> size the backing device, which matters when the backing files share a
> filesystem with the test data, and pass additional zloop parameters.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>  common/zoned | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/common/zoned b/common/zoned
> index 89d0a061..7fe794f9 100644
> --- a/common/zoned
> +++ b/common/zoned
> @@ -81,9 +81,17 @@ _create_zloop()
>          local conv_zones=",conv_zones=$3"
>      fi
>  
> +    if [ -n "$4" ]; then
> +        local capacity=",capacity_mb=$4"
> +    fi
> +
> +    if [ -n "$5" ]; then
> +        local extra=",$5"
> +    fi
> +
>      mkdir -p "$zloop_base/$id"
>  
> -    local zloop_args="add id=$id,base_dir=$zloop_base$zone_size$conv_zones"
> +    local zloop_args="add id=$id,base_dir=$zloop_base$zone_size$conv_zones$capacity$extra"

Looks good.

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

>  
>      echo "$zloop_args" > /dev/zloop-control || \
>          _fail "cannot create zloop device"
> -- 
> 2.56.0
> 
>