Re: [PATCH 16/25] xfs: add support for reading with data checksums

["Pankaj Raghav (Samsung)" <pankaj.raghav@linux.dev>]

On Wed, Nov 04, 2026 at 09:57:20AM +0100, Christoph Hellwig wrote:
> All reads from files with data checksums have the returned iomaps for
> data blocks limited to be inside a single RT csum file block, so that
> each data read only needs to deal with a single checksum buffer.
> 
> All reads on checksummed files need to use ioends so that the checksum
> can be verified from process context.  The ioend submission path looks
> up the checksum buffer and kicks of an asynchronous read of it.  The
> completion path waits for the buffer if needed and verifies the checksum.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/xfs/xfs_aops.c  |   3 +-
>  fs/xfs/xfs_ioend.c | 120 +++++++++++++++++++++++++++++++++++++++------
>  fs/xfs/xfs_iomap.c |  23 +++++++--
>  3 files changed, 126 insertions(+), 20 deletions(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index c30e688cfc9f..db834e5e60c1 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -601,7 +601,8 @@ xfs_get_iomap_read_ops(
>  {
>  	struct xfs_inode		*ip = XFS_I(mapping->host);
>  
> -	if (bdev_has_integrity_csum(xfs_inode_buftarg(ip)->bt_bdev))
> +	if (xfs_has_rtcsum(ip->i_mount) ||

Shouldn't this be xfs_is_rtcsum_inode(ip) instead of a per mount option?

> +	    bdev_has_integrity_csum(xfs_inode_buftarg(ip)->bt_bdev))
>  		return &xfs_iomap_read_ops;
>  	return &iomap_bio_read_ops;
>  }
-- 
Pankaj