Re: [PATCH 5/6] object-file: stop including "odb/source-loose.h"

[Patrick Steinhardt <ps@pks.im>]

On Tue, Nov 10, 2026 at 09:43:09PM +0530, Kaartic Sivaraam wrote:
> On 11/2/26 16:50, Patrick Steinhardt wrote:
> > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> > index ca3a891dfbc..e53c69af31f 100644
> > --- a/builtin/pack-objects.c
> > +++ b/builtin/pack-objects.c
> > @@ -34,6 +34,7 @@
> >   #include "object-file.h"
> 
> I think we can lose "object-file.h" in this one. The code seems to compile
> fine without it.

Only after step 6 though, because we implicitly depend on "git-zlib.h"
:)

> > diff --git a/http-walker.c b/http-walker.c
> > index 4f50dd9b8d0..13730a27847 100644
> > --- a/http-walker.c
> > +++ b/http-walker.c
> > @@ -11,6 +11,7 @@
> >   #include "packfile.h"
> >   #include "object-file.h"
> >   #include "odb.h"
> > +#include "odb/source-loose.h"
> 
> Ah ha. Looks like I was a bit premature. The http-walker.c change I proposed
> in 2/6 actually belongs here.

Yup, indeed.

> > diff --git a/object-file.h b/object-file.h
> > index 83d3f38a540..746356ceb51 100644
> > --- a/object-file.h
> > +++ b/object-file.h
> > @@ -4,7 +4,7 @@
> >   #include "git-zlib.h"
> >   #include "object.h"
> >   #include "odb.h"
> > -#include "odb/source-loose.h"
> > +#include "odb/streaming.h"
> 
> Do we really need odb/streaming.h? Code seems to compile and tests are happy
> even without it?

If it does then only by chance, as we do use `struct odb_stream` in this
header.

Patrick