From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
Yaron Shragai <yshragai.firmware@gmail.com>
Subject: Re: [libmnl PATCH] include: libmnl.h: Add explicit casts to macros for C++
Date: Wed, 11 Nov 2026 19:49:56 +0100 [thread overview]
Message-ID: <avS41B80NzkdEFeu@orbyte.nwl.cc> (raw)
In-Reply-To: <avSzl8-2uom7Mntt@strlen.de>
On Wed, Nov 11, 2026 at 07:27:35PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > C++ does not like implicit casts of void pointers, make them explicit
> > there. After adjusting similar cases in example source files, these are
> > the only needed header adjustments needed to compile them with g++.
>
> Reviewed-by: Florian Westphal <fw@strlen.de>
Applied after dropping the redundant "needed" up there. Thanks for your
review!
prev parent reply other threads:[~2026-11-11 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 15:30 [libmnl PATCH] include: libmnl.h: Add explicit casts to macros for C++ Phil Sutter
2026-11-11 18:27 ` Florian Westphal
2026-11-11 18:49 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avS41B80NzkdEFeu@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yshragai.firmware@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.