All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan@pereq.eu>
To: himanshu bakshi <himanshu.bakshi478@gmail.com>
Cc: gregkh@linuxfoundation.org, andy@kernel.org, error27@gmail.com,
	cenzhang@linux.microsoft.com, dennylin0707@gmail.com,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v4] staging: fbtft: remove unused fbtft_init_dbg()
Date: Wed, 11 Nov 2026 19:48:49 +0300	[thread overview]
Message-ID: <avSccSGIsu1EbwnN@stanley.mountain> (raw)
In-Reply-To: <20261111163819.143147-1-himanshu.bakshi478@gmail.com>

On Wed, Nov 11, 2026 at 10:08:19PM +0530, himanshu bakshi wrote:
> From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> 
> The fbtft_init_dbg() macro is not being used, so delete it.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> ---
> Changes in v4:
> - Add Reviewed-by from Andy Shevchenko.
> 

Collecting the tags is unnecessary.  Maintainers handle it.  You should
do it if you have to resend for a different reason but otherwise just
leave it.

regards,
dan carpenter


  reply	other threads:[~2026-11-11 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 16:38 [PATCH v4] staging: fbtft: remove unused fbtft_init_dbg() himanshu bakshi
2026-11-11 16:48 ` Dan Carpenter [this message]
2026-11-12 11:49 ` Hungyu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avSccSGIsu1EbwnN@stanley.mountain \
    --to=dan@pereq.eu \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=cenzhang@linux.microsoft.com \
    --cc=dennylin0707@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=himanshu.bakshi478@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.