Re: [PATCH] dm-integrity: initialize journal accounting in dm_integrity_ctr

[Benjamin Marzinski <bmarzins@redhat.com>]

On Wed, Nov 11, 2026 at 11:28:17AM -0500, Benjamin Marzinski wrote:
> On Wed, Nov 11, 2026 at 03:37:44PM +0100, Mikulas Patocka wrote:
> > I think that we shouldn't attempt to flush the journal at all when the 
> > device is in erroneous state - because flushing it could cause other 
> > problems.
> > 
> > I've created a patch that disables journal flushing if the dm-integrity 
> > device is disabled due to an error - please review it.
> 
> I was on the fence about doing something similar to your method. It does
> drop any previous journal writes to the partially filled uncommitted
> section, which is a bigger change than just fixing a kernel warning. But
> that's the way you think we should go, I'm fine with that.
> 
> The way I planned to solve it was (copy-pasted so the whitespace is all
> messed up):
> 
> diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c              
> index 1659a11a1a29..bf817c5ce2b3 100644                                         
> --- a/drivers/md/dm-integrity.c                                                 
> +++ b/drivers/md/dm-integrity.c                                                 
> @@ -2908,7 +2908,7 @@ static void integrity_commit(struct work_struct *w)       
>                                                                                 
>         spin_lock_irq(&ic->endio_wait.lock);                                    
>         flushes = bio_list_get(&ic->flush_bio_list);                            
> -       if (unlikely(ic->mode != 'J')) {                                        
> +       if (unlikely(ic->mode != 'J' || dm_integrity_failed(ic))) {             
>                 spin_unlock_irq(&ic->endio_wait.lock);                          
>                 dm_integrity_flush_buffers(ic, true);                           
>                 goto release_flush_bios;                                        
> 
> Even if we don't call dm_integrity_flush_buffers(), any dirty dm_bufio
> buffers still still get written out. By calling
> dm_integrity_flush_buffers(), we control when they get written out,
> and we want to guarantee that they get written out before we suspend.
> right?

Never mind. dm_integrity_postsuspend() will already call
dm_integrity_flush_buffers() after the queued commit_work is run, so the
dirty buffers are guaranteed to be written out. I'm fine with your
method (aside from the issue that sashiko caught).

-Ben
 
> -Ben
> 
> > Mikulas