Re: [PATCH 1/2] input: himax_hx83112b: Add hx83102d support

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Nov 11, 2026 at 05:33:54PM +0100, Henri Ommer wrote:
> The core functionality of the hx83102d is software-compatible with the hx83112b. As with the hx83112b, firmware flashing is unimplemented.
> This commit also adds support for touchscreen chips which do not have a reset GPIO, like the hx83102d in the Samsung Galaxy A20e.
> 
> Tested on: Samsung Galaxy A20e (SM-A202F)
> 
> Signed-off-by: Henri Ommer <henri.ommer@gmx.net>
> ---
>  drivers/input/touchscreen/himax_hx83112b.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/himax_hx83112b.c b/drivers/input/touchscreen/himax_hx83112b.c
> index 345ece27fe74..04c9c6aba396 100644
> --- a/drivers/input/touchscreen/himax_hx83112b.c
> +++ b/drivers/input/touchscreen/himax_hx83112b.c
> @@ -7,6 +7,9 @@
>   * HX83100A support
>   * Copyright (C) 2024 Felix Kaechele <felix@kaechele.ca>
>   *
> + * HX83102D support
> + * Copyright (C) 2026 Henri Ommer <henri.ommer@gmx.net>
> + *
>   * This code is based on "Himax Android Driver Sample Code for QCT platform":
>   *
>   * Copyright (C) 2017 Himax Corporation.
> @@ -132,6 +135,14 @@ static int himax_bus_read(struct himax_ts_data *ts, u32 address, void *dst,
>  
>  static void himax_reset(struct himax_ts_data *ts)
>  {
> +	/*
> +	 * Some versions of himax touchscreen chips do not contain a reset
> +	 * GPIO. The downstream driver only resets these chips for firmware
> +	 * updates (which aren't implemented in this driver)
> +	 */
> +	if (!ts->gpiod_rst)
> +		return;
> +
>  	gpiod_set_value_cansleep(ts->gpiod_rst, 1);
>  
>  	/* Delay copied from downstream driver */
> @@ -349,7 +360,7 @@ static int himax_probe(struct i2c_client *client)
>  		return error;
>  	}
>  
> -	ts->gpiod_rst = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +	ts->gpiod_rst = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);

This should be a separate patch please.

Thanks.

-- 
Dmitry