From: Michael Grzeschik <mgr@kernel.org>
To: John Ernberg <john.ernberg@actia.se>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nobuo Iwata <nobuo.iwata@fujixerox.co.jp>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wiliam Puranen <wiliam.puranen@actia.se>,
Michael Grzeschik <grzeschik@puzzle.ch>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usbip: Stop tracking work context in event_handler()
Date: Wed, 11 Nov 2026 23:13:14 +0100 [thread overview]
Message-ID: <avToeux2DxhBWGN4@toad.puzzle.ch> (raw)
In-Reply-To: <20260803104342.2790105-1-john.ernberg@actia.se>
Hi John,
On Mon, Aug 03, 2026 at 10:43:58AM +0000, John Ernberg wrote:
> From: Wiliam Puranen <wiliam.puranen@actia.se>
>
> The work queue used by usbip is not pinned to a specific context.
>
> When usbip_in_eh() evaluates if the call comes from the event handler
> it doesn't actually check if the call comes from the event handler but
> if the call comes from the same context as the event handler was first
> called from.
>
> This can result in "sticky" devices on the client side, due to the
> teardown path in stub_disconnect() being lied to, and thus skipping
> the teardown when it shouldn't, or vice versa.
>
> Fixes: bb7871ad99ea ("usbip: event handler as one thread")
> Cc: stable@vger.kernel.org # v4.6+
> Assisted-by: claude:opus-5
> Signed-off-by: Wiliam Puranen <wiliam.puranen@actia.se>
> Signed-off-by: John Ernberg <john.ernberg@actia.se>
Just as I stated in my other mail [1]. I just did send a near copy of
the change without knowing of this mail. But this one is the patch to
be taken.
Fixes: bb7871ad99ea ("usbip: event handler as one thread")
Reviewed-by: Michael Grzeschik <grzeschik@puzzle.ch>
[1]: https://lore.kernel.org/linux-usb/427d908d-1fa2-442c-ac91-b3e925e5c7bb@actia.se/T/#m2d50ad8abda5dc92fe6d8690edc0cab58983ab74
Thanks
Michael
prev parent reply other threads:[~2026-11-11 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 10:43 [PATCH] usbip: Stop tracking work context in event_handler() John Ernberg
2026-11-11 22:13 ` Michael Grzeschik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avToeux2DxhBWGN4@toad.puzzle.ch \
--to=mgr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grzeschik@puzzle.ch \
--cc=i@zenithal.me \
--cc=john.ernberg@actia.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nobuo.iwata@fujixerox.co.jp \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=wiliam.puranen@actia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.