Re: [PATCH 2/7] ufs: rpmb: stop the model string at its NUL terminator

[Carlo Caione <ccaione@baylibre.com>]

On Thu, Nov 12, 2026 at 07:44:55 +0100, Jorge Ramirez wrote:

Hi Jorge,

> > diff --git a/drivers/ufs/ufs-rpmb.c b/drivers/ufs/ufs-rpmb.c
> > index 508eb74d976..8b61760f071 100644
> > --- a/drivers/ufs/ufs-rpmb.c
> > +++ b/drivers/ufs/ufs-rpmb.c
> > @@ -270,6 +270,8 @@ static void ufs_rpmb_string_to_ascii(const u8 *raw, char *out, size_t outsz)
> >  	for (i = 0; i < nchars && n < (int)outsz - 1; i++) {
> >  		u16 c = get_unaligned_be16(raw + QUERY_DESC_HDR_SIZE + i * 2);
> >  
> > +		if (!c)
> > +			break;
> >  		out[n++] = (c >= 0x20 && c <= 0x7e) ? (char)c : ' ';
> >  	}
> >  	out[n] = '\0';
> 
> 
> have you tested this with Linux - RMPB access from u-boot and linux to confirm?
> AFAIR (plus the tests that I run) the code should match.

Yes, I did on a Genio 720 with a SK hynix HN8T05DJHVX105 UFS device.

The problem was that the device model descriptor contains two trailing
UTF-16 NULs. Linux's utf16s_to_utf8s() stops at the first NUL, while the
original U-Boot helper converts both to spaces:

  Original U-Boot: HN8T05DJHVX105<space><space>
  Linux/patched:  HN8T05DJHVX105

--
Carlo Caione