All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] iotests: fix false positive on running-outside-venv warning
Date: Thu, 12 Nov 2026 14:01:41 +0100	[thread overview]
Message-ID: <avW4tfoJj5sw6_Fl@redhat.com> (raw)
In-Reply-To: <20261007183338.1899422-1-jsnow@redhat.com>

Am 07.10.2026 um 20:33 hat John Snow geschrieben:
> Currently, iotests checks to see if you are running with the "correct"
> python interpreter by checking string equivalence between your current
> python and the configure-time venv python.
> 
> Depending on exactly *how* you launch or configure your python,
> however, this warning may produce false positives because it treats
> "python" as different from "python3" as different from
> e.g. "python3.12", even though they are all actually the same exact
> interpreter.
> 
> This patch fixes this by comparing only the parent directories; we
> will now be happy with any interpreter so long as it is located within
> build/pyvenv/bin/.
> 
> Note that we cannot fix this by resolving symlinks, as python venv
> binaries are often (but not always) just symlinks to /usr/bin/<etc>,
> and full resolution would produce even more false negatives.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: John Snow <jsnow@redhat.com>

Thanks, applied to the block branch.

Kevin



      reply	other threads:[~2026-11-12 13:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 18:33 [PATCH] iotests: fix false positive on running-outside-venv warning John Snow
2026-11-12 13:01 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avW4tfoJj5sw6_Fl@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.