Re: [PATCH] backends/hostmem: Factor out "property still settable" check

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Nov 12, 2026 at 12:51:42PM +0100, Markus Armbruster wrote:
> We check whether a property can still be set like this:
> 
>     if (host_memory_backend_mr_inited(backend)) {
>         error_setg(errp, ...);
>         return;
>     }
> 
> The actual error messages vary a bit.  Most are like
> 
>     cannot change property 'PROP-NAME' of TYPE-NAME
> 
> but we also have
> 
>     cannot change property value
> 
> Factor out into host_memory_backend_settable() so we can instead use:
> 
>     if (!host_memory_backend_settable(backend, name, errp)) {
>         return;
>     }
> 
> The error message is now always
> 
>     cannot change property 'PROP-NAME' of 'TYPE-NAME'
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/system/hostmem.h |  2 ++
>  backends/hostmem-file.c  | 24 ++++++------------------
>  backends/hostmem-memfd.c |  3 +--
>  backends/hostmem.c       | 21 ++++++++++++++-------
>  4 files changed, 23 insertions(+), 27 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|