From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/4] crypto: robustness fixes to handling of SM3 hash
Date: Thu, 12 Nov 2026 18:00:07 +0000 [thread overview]
Message-ID: <avX-p7BYUovjL7PB@redhat.com> (raw)
In-Reply-To: <20261102122343.3348956-1-berrange@redhat.com>
ping: i'd like to get this fix into 11.2
On Mon, Nov 02, 2026 at 12:23:39PM +0000, Daniel P. Berrangé wrote:
> Note that patch 4 is best reviewed by applying to git and then using
> 'git show -b' to hide the huge whitespace indentation change.
>
> Changed in v2:
>
> * Use array range initializer for setting default value
> * Drop redundant countermeasures now we can gurantee a
> correct default initializer value
> * Drop SM3 conditions in tests
> * Refactor tests to register one test per algorithm
>
> Daniel P. Berrangé (4):
> crypto: set default initializer hmac/hash arrays to -1
> crypto: unconditionally report SM3 hash length
> tests/unit: drop conditionals for SM3
> tests/unit: register one test per hash/hmac algorithm
>
> crypto/hash-glib.c | 3 +-
> crypto/hash.c | 4 +-
> crypto/hmac-glib.c | 4 +-
> tests/unit/test-crypto-hash.c | 325 +++++++++++++++-------------------
> tests/unit/test-crypto-hmac.c | 272 +++++++++++++---------------
> 5 files changed, 275 insertions(+), 333 deletions(-)
>
> --
> 2.56.0
>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-11-12 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 12:23 [PATCH v2 0/4] crypto: robustness fixes to handling of SM3 hash Daniel P. Berrangé
2026-11-02 12:23 ` [PATCH v2 1/4] crypto: set default initializer hmac/hash arrays to -1 Daniel P. Berrangé
2026-11-02 12:23 ` [PATCH v2 2/4] crypto: unconditionally report SM3 hash length Daniel P. Berrangé
2026-11-02 12:23 ` [PATCH v2 3/4] tests/unit: drop conditionals for SM3 Daniel P. Berrangé
2026-11-02 12:23 ` [PATCH v2 4/4] tests/unit: register one test per hash/hmac algorithm Daniel P. Berrangé
2026-11-12 18:00 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avX-p7BYUovjL7PB@redhat.com \
--to=berrange@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.