From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4C9606A334 for ; Thu, 12 Nov 2026 16:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M+gSRJBP Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRXu5-0006pR-9O; Thu, 12 Nov 2026 11:44:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRXtz-0006i3-En for qemu-devel@nongnu.org; Thu, 12 Nov 2026 11:43:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRXtx-0003Ud-IS for qemu-devel@nongnu.org; Thu, 12 Nov 2026 11:43:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794501832; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=37CCPBuZKSq9ynoDFziWp2z6f8eGYOzxwjI4W3dtxLc=; b=M+gSRJBPdDZgD7rqgMdMtx2woycoLYYobe29UX9xQ2jpAOPCq82gkuePsDhGY+MoTVMF0F aYeryAR/0XQ+FlpI+DXMIKPZizkWf6kqlVT7Q+TxkvMbkrp7lfCsOGraKfDnuui9L8N5xO wmuoIPqhepWnMy/ige3oe62YWJzbSFs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-z3eWy5C9MMyGgPbmkO97_A-1; Thu, 12 Nov 2026 11:43:48 -0500 X-MC-Unique: z3eWy5C9MMyGgPbmkO97_A-1 X-Mimecast-MFC-AGG-ID: z3eWy5C9MMyGgPbmkO97_A_1794501827 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2B45B19560B5; Thu, 12 Nov 2026 16:43:45 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4ACB730000E8; Thu, 12 Nov 2026 16:43:40 +0000 (UTC) Date: Thu, 12 Nov 2026 16:43:37 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Pierrick Bouvier , Gerd Hoffmann , xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org, "Edgar E. Iglesias" , Eric Blake , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Anthony PERARD , Paolo Bonzini , Stefano Stabellini , Alexey Kardashevskiy , Richard Henderson , Helge Deller , Stefan Hajnoczi Subject: Re: [PULL v2 23/25] trace: stop tracking static disabled state Message-ID: References: <20261104201802.11556-1-stefanha@redhat.com> <20261104201802.11556-24-stefanha@redhat.com> <87se1efa5p.fsf@pond.sub.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87se1efa5p.fsf@pond.sub.org> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 06, 2026 at 12:53:54PM +0100, Markus Armbruster wrote: > I missed this, because I wasn't cc'ed. > > Stefan Hajnoczi writes: > > > From: Daniel P. Berrangé > > > > The TraceEvent struct contains a "bool sstate" field which track whether > > a trace event was disabled statically. i.e. at build time via the > > "disable" property annotation in trace-events. > > > > The only runtime use of this field is to let "trace-event-get-state" > > report that an event is "unavailable" instead of reporting an error for > > an unknown trace event. > > > > Trace events are not ABI so their names can change and the event can > > come and go at any time. Thus there is little utility in reporting the > > existence of a disabled event that cannot ever be used at runtime. > > > > Removing the "bool sstate" field from TraceEvent saves 8 bytes of > > space in the struct, adding up to approx 64 KB across all current > > events. > > > > Reviewed-by: Marc-André Lureau > > Signed-off-by: Daniel P. Berrangé > > Message-id: 20261102142844.3464712-24-berrange@redhat.com > > Signed-off-by: Stefan Hajnoczi > > [...] > > > diff --git a/qapi/trace.json b/qapi/trace.json > > index 29c76256055..8533e378977 100644 > > --- a/qapi/trace.json > > +++ b/qapi/trace.json > > @@ -16,8 +16,6 @@ > > # @TraceEventState: > > # State of a tracing event. > > # > > -# @unavailable: The event is statically disabled. > > -# > > # @disabled: The event is dynamically disabled. > > # > > # @enabled: The event is dynamically enabled. > > @@ -25,7 +23,7 @@ > > # Since: 2.2 > > ## > > { 'enum': 'TraceEventState', > > - 'data': ['unavailable', 'disabled', 'enabled'] } > > + 'data': ['disabled', 'enabled'] } > > No note in docs/about/removed-features.rst needed? Yes it is required. > > @@ -69,6 +67,7 @@ > ## > # @trace-event-set-state: > # Set the dynamic tracing state of events. > # > # @name: Event name pattern (case-sensitive glob). > # > > # @enable: Whether to enable tracing. > > # > > # @ignore-unavailable: Do not match unavailable events with @name. > > +# Deprecated: since 11.2 > > # > > # Since: 2.2 > > # > > Are you trying to deprecate use of argument @ignore-unavailable? Yes. > If yes, this isn't how we do that. Instead: /face-palm > > ## > # @trace-event-set-state: > # Set the dynamic tracing state of events. > # > # @name: Event name pattern (case-sensitive glob). > # > # @enable: Whether to enable tracing. > # > # @ignore-unavailable: Do not match unavailable events with @name. > # > # Features: > # > # @deprecated: Argument @ignore-unavailable is deperecated and does > # nothing. > # > # Since: 2.2 > # > # .. qmp-example:: > # > # -> { "execute": "trace-event-set-state", > # "arguments": { "name": "qemu_memalign", "enable": true } } > # <- { "return": {} } > ## > { 'command': 'trace-event-set-state', > 'data': {'name': 'str', 'enable': 'bool', > '*ignore-unavailable': { 'type': 'bool', > 'features': [ 'deprecated' ] } } } > > with a matching update to docs/about/deprecated.rst. Yes, will CC you on the fix. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|