From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795160918; b=YRiVL0najmnuT/6kkVPQICEPt5e8+JlijFDm9EIopxuASCcflXC92xyzrbLH2UMDX4ia ZeCVP4Jd9wbhEhPFuLn2P9DNj4PpQb7tvNX+KtayzI18PN12ElFKi/xitqHCgiFKPzARz aZrbRDE+hqFfKnbMIH2qNro7ru1EMLPKunW3psGxVhZdmHJQ8XH4cSMy2DuNATNZPRzF3 gb1Si/EkBuWrY3qqs0lFZUTK9hMEQ18QY0w+zsvhLg+87wlTdbVu7hyrYNCFbh9JL2AUA uHvwvcmdNxLHOWeOZcJc584mraL0xV3XiDnr+TcPpv19BUT/MEghad9gY4F42Of+pHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795160918; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=87RNaaNfdLcFk4ZTuxhuFbTHIbFpjHDXzWzIK6yaLPw=; b=EjLu8k+go+Wpp2YkE7vzg4R6rPhTQJPOrO0WtiEfNgFWozl84cS1YBMyXyAokHr6E0AU v8euzYSB+qssqndaxTzosx7C2+0XKTRun63eisBW5YZA3aD1YU4vBjKMS4S1JGLJ6IVcB X8cukfIW0m9O221ktnpFcdyKMU3YYwZJfHVGvZGpECurzx4Ff1cf5Cx3oIZz8ZGytuLB0 3cGrPGj1hcD7Igm/CfZgmB50yb6yePFbzlJTSzG87Y+VtCph+WKa6RlylsfDby7zjTDnM KsZnFAeWkydB2wk2xuYK5IMFwtMJZT8fEngfwThFR9sJLD5aRd/8m3hpgjsc+0FkqdQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=iOQAV6V5; arc=none smtp.remote-ip=209.85.215.171 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9EC9606A320 for ; Fri, 20 Nov 2026 07:48:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C9EC9606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=iOQAV6V5 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cde5a7d7849so284860a12.0 for ; Thu, 19 Nov 2026 23:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1795160916; x=1795765716; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=87RNaaNfdLcFk4ZTuxhuFbTHIbFpjHDXzWzIK6yaLPw=; b=iOQAV6V57g9K0YlldSj9LmecEMMwpyS9SeJNol1ZGRWm+UQ/liCICKdu6zJSw7jcJL S7AEd5UVaCeJHqmBUBWRc8DNbtmuaPlXYpHyrpDBmuHVj2zfQ6NMErcrVdAQUkSXOdhf nbjHfwyaZNEorYNr4+k5x0647N0HDy+dSaeSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795160916; x=1795765716; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=87RNaaNfdLcFk4ZTuxhuFbTHIbFpjHDXzWzIK6yaLPw=; b=RwJEkZOXEbxRCr3S8mRU2P+4CVSVLOM2qEzFOqzNU3RsSB3W6C5tTLU7vzfg/mo6a1 9dLflKmFhXkxDMyDfiKDAW0shCTiuTpA0Q+CYUeFO5ej8mpsMn4RuAS5+KYp2HMXaOCQ yJrzeqwtR5ady8vYZf1PoLxdG3YgKRCVLtnM3ij1OIj4Brx2+Vh2h727vtqiZb/2lDgX gFVHVwU2jT1cPyq0uSbagF4xmM9mFIul+8QzHh8MsDP8G+oiGg0whIRcWkp5/uYbfi3k 88oFyG/jsEmkpf6vlTh8xMsACr/YlDQeGYDOpetmcuhoksPCa+SktfAOL3c1calbnt1/ o99Q== X-Forwarded-Encrypted: i=1; AL+hErE7LpkbEkqoYKDP2tchSTXmXxK/PUXjFqPGRqmk3Ln+sQ1w5eAiSKRPQ3EwI6p4wyqLxcEwc2jp0OGlTg==@vger.kernel.org X-Gm-Message-State: APuU4Z/ffD+zGPJIZN5PUYluNbcbiODdJsJqKv0pVDxtvMqHNZQ8pPlI m2qyF2KQ90xkAOKJUyumy4m2XwOBnW5PWzp3qetfOU9SD8GSHrlgd5sxKPx02CLb3Q== X-Gm-Gg: AZFdTZe+qbOTTqM+93Z0BYfasgPWk6mgtJG69QifM6I6iVWynxqkgIg9+M9YzFrWck9 z0PePX2Y/iGtFtMx5YAzBPUQB9Mx72V7BYsoNCaGOvXA6Mm9jqcvfitH1CIislazv+H+N7SsdXS a3ACmWYvHInFqaB3NC0ady9G8tEA+tuHiX48NtUkdwloWC6HOm9d18kI/26abkO9IvQXXajFoXg s7Doo53wHIl3xyDcWehTf3WdsdiAq5OVIe5CEF0sR70l4SHpGszkjlxE+UV9B5gm1qG5VqRi8DN lsfdumJnOkfPdKLkOduA7Wqqa9XH1jH+4/ApZOSAO7ntoabNHZp+5nRN16J1/xTnOovUcI1Zd2e ddHiNjIoksYrDV07A/VngCc56rGsIF6h3sAXfL1kJ87h9ZY++gxFAastx1xu8QQgtyx2VbiKhac MMQwXalaOj+8w+FObyJqKpRkZKdAAKkzVrrZW2bqIE/2vQAjmr7KNO+yocjVX4tRqElAoNAhHQy 1iEWF8PxePXHiqcA6KiAyKOfzb47deShTBuW+fTHNpR2Fwe/33miL/yjz1QUYVl3uZMby8aqeJc nTKEkBFLmSHCYgm8pYN7+Nr5egIEK8v3/X5BFaVR3/zt7xjl04RILOsl3jgGNNyITRxDkA== X-Received: by 2002:a17:90b:4a4f:b0:3ac:8af9:4a6a with SMTP id 98e67ed59e1d1-3b41c93c3b7mr2039531a91.42.1795160916074; Thu, 19 Nov 2026 23:48:36 -0800 (PST) Received: from google.com ([2a00:79e0:2031:6:d5a5:46fe:fd42:7b73]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b420000deesm1063037a91.0.2026.11.19.23.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 23:48:35 -0800 (PST) Date: Fri, 20 Nov 2026 16:48:30 +0900 From: Sergey Senozhatsky To: Hongfeng Chen , Nhat Pham Cc: Hongfeng Chen , Andrew Morton , Barry Song , Chengming Zhou , Jens Axboe , Johannes Weiner , Minchan Kim , Shakeel Butt , Yosry Ahmed , Wenchao Hao , Wenchao Hao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Hongfeng Chen , Sergey Senozhatsky Subject: Re: [RFC PATCH v4 0/2] mm/zsmalloc: defer object free to per-cpu batches Message-ID: References: <20261016120927.3191690-1-hongfengchen@xiaomi.com> <20261023123736.1542117-1-chenhongfeng0212@163.com> <20261109105957.2577351-1-chenhongfeng0212@gmail.com> X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/11/20 10:44), Sergey Senozhatsky wrote: > On (26/11/19 14:35), Sergey Senozhatsky wrote: > > On (26/11/09 18:59), Hongfeng Chen wrote: > > > On Fri, Oct 23, 2026 at 11:19 AM Nhat Pham wrote: > > > > Is there any more juice we can squeeze from zsmalloc in that case? > > > > > > > > It would be nice if you can perf zsmalloc freeing. And yeah, maybe we > > > > can't optimize any further, but let's eliminate that first before we > > > > rely on offloading. > > > > > > Here is the perf breakdown of the free path: > > > > > > zram: > > > > > > __swap_cluster_free_entries 90.28% > > > zram_slot_free_notify 86.01% > > > slot_free 74.15% > > > zs_free 56.01% > > > __free_frozen_pages 19.85% > > > kmem_cache_free 10.15% > > > _raw_spin_lock 5.53% > > > fix_fullness_group 3.31% > > > dec_zone_page_state 2.43% > > > obj_free 2.17% > > > trylock_zspage 2.12% > > > > We removed one of kmem_cache_free() from zs_free() [1]. > > > > [1] https://lore.kernel.org/linux-kernel/20261110054836.1515030-1-senozhatsky@chromium.org > > I suppose we can batch some operations in zs_free(), something like > this: A slightly reworked patch below - handle incompressible and pow-of-two zspages separately (w/o batching), because those are 1-page zspages, nothing to batch. --- mm/zsmalloc.c | 52 +++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 46 insertions(+), 6 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index f571b3c9e9ca..9dcd1549c2fb 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include "zpdesc.h" @@ -866,6 +867,44 @@ static int trylock_zspage(struct zspage *zspage) return 0; } +/* + * Free the pages of a multi-page zspage in one go, see folios_put(). + * Not inlined, so that the folio_batch is only set up (and, with + * CONFIG_INIT_STACK_ALL_ZERO, zero-filled) when there is something + * to batch. + */ +static noinline void free_page_chain(struct zpdesc *zpdesc) +{ + struct zone *zone = zpdesc_zone(zpdesc); + struct folio_batch fbatch; + int nr = 0; + + static_assert(ZS_MAX_PAGES_PER_ZSPAGE <= FOLIO_BATCH_SIZE); + + folio_batch_init(&fbatch); + do { + struct zpdesc *next = get_next_zpdesc(zpdesc); + + VM_BUG_ON_PAGE(!zpdesc_is_locked(zpdesc), zpdesc_page(zpdesc)); + reset_zpdesc(zpdesc); + zpdesc_unlock(zpdesc); + + /* NR_ZSPAGES is per zone: one update per same-zone run */ + if (unlikely(zpdesc_zone(zpdesc) != zone)) { + mod_zone_page_state(zone, NR_ZSPAGES, -nr); + zone = zpdesc_zone(zpdesc); + nr = 0; + } + nr++; + + folio_batch_add(&fbatch, zpdesc_folio(zpdesc)); + zpdesc = next; + } while (zpdesc); + + mod_zone_page_state(zone, NR_ZSPAGES, -nr); + folios_put(&fbatch); +} + /* * Three free helpers, kept apart here: * @@ -884,21 +923,22 @@ static int trylock_zspage(struct zspage *zspage) */ static inline void __free_zspage_lockless(struct zspage *zspage) { - struct zpdesc *zpdesc, *next; + struct zpdesc *zpdesc; VM_BUG_ON(get_zspage_inuse(zspage)); VM_BUG_ON(zspage->fullness != ZS_INUSE_RATIO_0); - next = zpdesc = get_first_zpdesc(zspage); - do { + zpdesc = get_first_zpdesc(zspage); + if (get_next_zpdesc(zpdesc)) { + free_page_chain(zpdesc); + } else { + /* Single-page zspage, e.g. a huge object: nothing to batch */ VM_BUG_ON_PAGE(!zpdesc_is_locked(zpdesc), zpdesc_page(zpdesc)); - next = get_next_zpdesc(zpdesc); reset_zpdesc(zpdesc); zpdesc_unlock(zpdesc); zpdesc_dec_zone_page_state(zpdesc); zpdesc_put(zpdesc); - zpdesc = next; - } while (zpdesc != NULL); + } cache_free_zspage(zspage); } -- 2.56.1.750.gf70dc682cf-goog