From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: Matthieu Baerts <matttbe@kernel.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
fw@strlen.de, phil@nwl.cc
Subject: Re: [PATCH nf-next RFC] netfilter: nft_exthdr: add inner option type search for MPTCP
Date: Fri, 13 Nov 2026 11:07:46 +0100 [thread overview]
Message-ID: <avbhcvVfMptkFUyV@chamomile> (raw)
In-Reply-To: <31dae787-d58e-4b45-815d-e79670906767@suse.de>
One more comment.
On Fri, Oct 09, 2026 at 03:05:34PM +0200, Fernando Fernandez Mancera wrote:
> On 10/9/26 12:22 PM, Matthieu Baerts wrote:
[...]
> >
> > > + if (!(optl >= 3 && (opt[i + 2] >> 4) == priv->inner_type))
> >
> > Can you not use priv->offset and priv->len not to have something
> > specific to MPTCP?
> >
> > But then, you need to keep the safety check around them before this. And
> > you probably need to check that the length is <= 8 at parsing time.
> >
>
> We could allow that but I do not have an usecase right now. If we do have
> one, please let me know. This new _INNER_TYPE option can be also used for
> SCTP for example, but that would need to be implemented later.
Would it be easier to add the SCTP support later if this is all
generic? Or generalizing it as Matthieu suggest is too much work?
This will require a new kernel patch in the future. Allowing for
userspace updates to support new feature is convenient.
This is not a deal breaker, let me know.
next prev parent reply other threads:[~2026-11-13 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 17:40 [PATCH nf-next RFC] netfilter: nft_exthdr: add inner option type search for MPTCP Fernando Fernandez Mancera
2026-10-09 10:22 ` Matthieu Baerts
2026-10-09 13:05 ` Fernando Fernandez Mancera
2026-11-13 10:07 ` Pablo Neira Ayuso [this message]
2026-11-13 10:04 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avbhcvVfMptkFUyV@chamomile \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=matttbe@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.