From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2922606A327 for ; Fri, 13 Nov 2026 10:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Np2ZXOdV Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRoXY-0006Y4-Sr; Fri, 13 Nov 2026 05:29:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRoXW-0006Xi-9j for qemu-devel@nongnu.org; Fri, 13 Nov 2026 05:29:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRoXU-00065w-JZ for qemu-devel@nongnu.org; Fri, 13 Nov 2026 05:29:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794565787; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0+LnC4NOoHGjXKgt2svlk6W0y2AuZPaPx5AmHTg3YOQ=; b=Np2ZXOdV74XNLeGbXHqHtKKlBzhfBKLqAyDYW0y81GbMNT2y7lvM1rU/U9uzGCFEoBJRJX 5uHJDBWlKr9vP2eec1447dggk1Ss8iK6kxS8U65A65MlYS3/bBcQQ0LrEWA3DK5kuDPk// vkFdOd3x5fFhVD2vsxYYWx9aNNqggHU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-1J9hfeuPMlCTdrv5Q7JZWg-1; Fri, 13 Nov 2026 05:29:44 -0500 X-MC-Unique: 1J9hfeuPMlCTdrv5Q7JZWg-1 X-Mimecast-MFC-AGG-ID: 1J9hfeuPMlCTdrv5Q7JZWg_1794565782 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C122418002AD; Fri, 13 Nov 2026 10:29:41 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4346A195E489; Fri, 13 Nov 2026 10:29:38 +0000 (UTC) Date: Fri, 13 Nov 2026 10:29:35 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, Pierrick Bouvier , Matthew Rosato , "Michael S. Tsirkin" , Paolo Bonzini , "Edgar E. Iglesias" , Eric Farman , Cornelia Huck , Philippe Mathieu-Daude , David Hildenbrand , Fam Zheng , qemu-s390x@nongnu.org Subject: Re: [PATCH v2 4/4] hw/microblaze: defer PetaLogix endianness default until init Message-ID: References: <20261105194958.1117-1-luoyonggang@gmail.com> <20261105194958.1117-5-luoyonggang@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261105194958.1117-5-luoyonggang@gmail.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 06, 2026 at 03:49:57AM +0800, Yonggang Luo wrote: > The PetaLogix machine read its endianness default from > target_big_endian() in class_init. In a multi-target binary the target > is not selected yet at class_init, so the default cannot be computed > there. Set the property default to "unspecified" instead, and resolve > it to big or little in petalogix_s3adsp1800_init(), where the target is > known. > > Until the machine is initialized, endianness reads back as > "unspecified" rather than big or little. > > Reviewed-by: Pierrick Bouvier > Signed-off-by: Yonggang Luo > --- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|