From: Breno Leitao <leitao@debian.org>
To: riel@surriel.com, bp@alien8.de
Cc: Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH RESEND v2] x86/mce: Rate-limit the CMCI storm transition notices
Date: Fri, 13 Nov 2026 04:35:47 -0800 [thread overview]
Message-ID: <avcD0tq_Q-vlT-ya@gmail.com> (raw)
In-Reply-To: <20261112182125.GDavYDpdJpmpU2Piyu@fat_crate.local>
On Thu, Nov 12, 2026 at 10:21:25AM -0800, Borislav Petkov wrote:
> On Thu, Nov 12, 2026 at 01:56:39AM -0800, Breno Leitao wrote:
> > void mce_track_storm(struct mce *mce)
> > {
> > struct mca_storm_desc *storm = this_cpu_ptr(&storm_desc);
> > @@ -150,13 +158,17 @@ void mce_track_storm(struct mce *mce)
> > if (storm->banks[mce->bank].in_storm_mode) {
> > if (history & GENMASK_ULL(STORM_END_POLL_THRESHOLD, 0))
> > return;
> > - printk_deferred(KERN_NOTICE "CPU%d BANK%d CMCI storm subsided\n", smp_processor_id(), mce->bank);
> > + if (__ratelimit(&storm_rs))
> > + printk_deferred(KERN_NOTICE "CPU%d BANK%d CMCI storm subsided\n",
> > + smp_processor_id(), mce->bank);
> > mce_handle_storm(mce->bank, false);
> > cmci_storm_end(mce->bank);
> > } else {
> > if (hweight64(history) < STORM_BEGIN_THRESHOLD)
> > return;
> > - printk_deferred(KERN_NOTICE "CPU%d BANK%d CMCI storm detected\n", smp_processor_id(), mce->bank);
> > + if (__ratelimit(&storm_rs))
> > + printk_deferred(KERN_NOTICE "CPU%d BANK%d CMCI storm detected\n",
> > + smp_processor_id(), mce->bank);
> > mce_handle_storm(mce->bank, true);
> > cmci_storm_begin(mce->bank);
> > }
>
> Should we merge all the MCE ratelimiting into a single effort?
>
> https://lore.kernel.org/r/20261108143751.3af49e48@fangorn
Sounds good. I will send v3 as one series: Rik's patch first, since it
is a stable fix and can go in on its own, and the storm notice ratelimit
on top of it.
prev parent reply other threads:[~2026-11-13 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 9:56 [PATCH RESEND v2] x86/mce: Rate-limit the CMCI storm transition notices Breno Leitao
2026-11-12 18:21 ` Borislav Petkov
2026-11-13 12:35 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avcD0tq_Q-vlT-ya@gmail.com \
--to=leitao@debian.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernel-team@meta.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=riel@surriel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.