Re: [PULL 0/8] NBD patches through 2026-11-10

[Eric Blake <eblake@redhat.com>]

On Fri, Nov 13, 2026 at 09:12:09AM +0100, guillaume vincke wrote:
> > > Markus, what are your thoughts on a QMP addition this late into 11.2
> > > so that the test in 2/8 can be stable? I'm torn on whether the NBD bug
> > > in 1/8 is severe enough to need to go in 11.2.0 proper, or whether the
> > > bug is weak enough that it is safer to wait until 11.2.1 via the
> > > qemu-stable process.  Patches 3-8 fix CVEs, so they definitely belong
> > > in 11.2.
> > 
> > "Only bug fixes" since soft freeze.  The closer we get to the release,
> > the more serious the bugs need to be.
> > 
> > Including tests with the bug fixes feels okay to me.  Test
> > infrastructure in QEMU proper, like a QMP command, is pushing it,
> > though.
> > 
> > What's the impact of omitting or disabling the troublesome test until
> > after the release?
> 
> In my opinion, the 1/8 fix and the associated 2/8 test can be postponed
> to the next release. That behavior has been there for a long time and,
> as far as I know, nobody but me has complained about it. Taking the
> time to get a robust test in is probably the safer option.

That settles it. I'm saving both Guillame's bug fix and the unit test
for 12.0 when we can also pick up the QMP changes to make the unit
test robust; and planning a strong possibility of backporting the bug
fix, but not the unit test, to 11.2.1 once the 11.2 release is out.  I
will respin this pull request accordingly.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org