Re: [PATCH RESEND 0/5] ata: fix platform driver probe, removal and locking issues

[Niklas Cassel <cassel@kernel.org>]

Hello Shao,

On Sat, Nov 14, 2026 at 02:03:05AM +0800, shao.mingyin@zte.com.cn wrote:
> The ATA platform drivers in this series have independent defects in
> their probe, removal or locking paths.  They share the same shape:
> state established in probe is not checked, torn down or serialized
> consistently.
> 
> Patch 1 fixes recursive locking in the IXP4xx CF PIO callback, which
> can hang the first data transfer, including IDENTIFY during probe.  Patch 2
> returns the host activation error from the Buddha probe path instead of
> reporting a successful bind.  Patch 3 makes the QorIQ and Seattle
> drivers inherit ahci_platform_ops so that host teardown runs host_stop.
> Patch 4 stops only the Gemini SATA bridges that started successfully.
> Patch 5 serializes the controller-wide SGPIO update in the Seattle LED
> callback.
> 
> Each patch touches one driver, except patch 3, which covers the QorIQ
> and Seattle AHCI platform drivers.  The patches are independent and any
> subset can be applied; the order lists the more severe failures first.
> 
> All five patches carry QEMU A/B test descriptions after the --- line.
> 
> This is a resend of [1].  Patches 1/5 and 3/5 lost their final
> context line in transport, so git apply reported a corrupt patch;
> 5/5 had the same trailing line.  The diff content is unchanged; all
> five patches now end with the format-patch signature, which keeps the
> blank context line in place.  Sorry for the noise.
> 
> [1] https://lore.kernel.org/all/20261112221230052E8YTrPU5pi8AJJy6dnh9E@zte.com.cn/
> 
> Shao Mingyin (5):
>   ata: pata_ixp4xx_cf: avoid recursive locking in the PIO callback
>   ata: pata_buddha: propagate host activation errors
>   ata: ahci: release QorIQ and Seattle platform resources on removal
>   ata: pata_ftide010: stop only successfully started Gemini bridges
>   ata: ahci_seattle: serialize SGPIO register updates
> 
>  drivers/ata/ahci_qoriq.c     |  2 +-
>  drivers/ata/ahci_seattle.c   |  8 ++++----
>  drivers/ata/pata_buddha.c    |  6 ++----
>  drivers/ata/pata_ftide010.c  | 37 +++++++++++++++++++------------------
>  drivers/ata/pata_ixp4xx_cf.c |  5 +----
>  5 files changed, 27 insertions(+), 31 deletions(-)
> 
> ---
> base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b

This series looks good to me.

Unless any review comment shows up, I will apply it early next week.


Kind regards,
Niklas