From: Bobby Eshleman <bobbyeshleman@meta.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <netdev@vger.kernel.org>, David Ahern <dsahern@kernel.org>,
Stefano Garzarella <sgarzare@redhat.com>,
<virtualization@lists.linux.dev>
Subject: Re: [PATCH RFC iproute2-next 2/2] ip: add "ip vsock" to move the guest vsock device to a netns
Date: Fri, 13 Nov 2026 13:34:07 -0800 [thread overview]
Message-ID: <aveCT0JPHPsqCkL4@devvm29614.prn0.facebook.com> (raw)
In-Reply-To: <20261106102659.77f8ba56@stephen-xps.local>
On Fri, Nov 06, 2026 at 10:26:59AM +0100, Stephen Hemminger wrote:
> On Thu, 5 Nov 2026 11:30:36 -0800
> Bobby Eshleman <bobbyeshleman@meta.com> wrote:
>
> > + * The guest's vsock device is not a netdev, so rtnetlink cannot move it.
> > + * The "vsock" generic netlink family moves it with VSOCK_CMD_DEV_NETNS_SET
> > + * and reports where it is with VSOCK_CMD_DEV_NETNS_GET. There is nothing to
> > + * name in a request: the kernel serves it in the namespace of the socket it
> > + * arrived on, so the destination is chosen by sending it from there, and the
> > + * reported namespace is an nsid relative to the sender.
> > + */
>
> Please be more concise in comments, AI seems to think it gets paid by word.
True, will definitely shrink this down.
Best,
Bobby
next prev parent reply other threads:[~2026-11-13 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 19:30 [PATCH RFC iproute2-next 0/2] ip: add "ip vsock" to move the guest vsock device to a netns Bobby Eshleman
2026-11-05 19:30 ` [PATCH RFC iproute2-next 1/2] uapi: add vsock_netlink.h Bobby Eshleman
2026-11-05 19:30 ` [PATCH RFC iproute2-next 2/2] ip: add "ip vsock" to move the guest vsock device to a netns Bobby Eshleman
2026-11-06 9:26 ` Stephen Hemminger
2026-11-13 21:34 ` Bobby Eshleman [this message]
2026-11-06 9:36 ` Stephen Hemminger
2026-11-13 21:35 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aveCT0JPHPsqCkL4@devvm29614.prn0.facebook.com \
--to=bobbyeshleman@meta.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.