From: Dan Carpenter <error27@gmail.com>
To: Rishiraj Rajgor <rishirajrajgor@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager: add newline to sysfs_emit formats
Date: Sat, 14 Nov 2026 08:02:15 +0300 [thread overview]
Message-ID: <avfrV0bQO3nvDkbH@stanley.mountain> (raw)
In-Reply-To: <20261113130324.34353-1-rishirajrajgor@gmail.com>
On Fri, Nov 13, 2026 at 06:33:24PM +0530, Rishiraj Rajgor wrote:
> According to sysfs guidelines and checkpatch SYSFS_EMIT rule, sysfs
> show functions should terminate outputs with a newline. The show
> functions in audio_manager_module.c omit the newline character from
> their sysfs_emit() format strings.
>
> Add a terminating newline to all sysfs_emit() format strings in
> gb_audio_module_*_show() functions.
>
> Signed-off-by: Rishiraj Rajgor <rishirajrajgor@gmail.com>
> ---
No, see the mail archives for why.
regards,
dan carpenter
prev parent reply other threads:[~2026-11-14 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 13:03 [PATCH] staging: greybus: audio_manager: add newline to sysfs_emit formats Rishiraj Rajgor
2026-11-14 5:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avfrV0bQO3nvDkbH@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=rishirajrajgor@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.