All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Jardin via buildroot <buildroot@buildroot.org>
To: Leo Denieul <leo.denieul.yoshino@gmail.com>
Cc: buildroot@buildroot.org, Dick Olsson <hi@senzilla.io>,
	Sergey Matyukevich <geomatsi@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] board/freescale/lx2160a-rdb: add secure boot support
Date: Sat, 14 Nov 2026 10:58:55 +0100	[thread overview]
Message-ID: <avgw38JrRMWJUIUt@L30177.local> (raw)
In-Reply-To: <474ec5cfc432c4b9e9413ee991ccb9d0763c9392.1794475724.git.leo.denieul.yoshino@gmail.com>

Hi Leo,

> +if grep -q "^BR2_TARGET_ARM_TRUSTED_FIRMWARE_NXP_SECURE_BOOT=y" "$BR2_CONFIG"; then
> +    sed -i -e 's/"bl2_sd.pbl"/"bl2_sd_sec.pbl"/' \
> +        -e 's/"fip_ddr.bin"/"ddr_fip_sec.bin"/' \
> +        "$BINARIES_DIR/genimage.cfg"
> +fi

What if the names of those files are different ? since their names
are not enforced and can be freely set with:

BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES="fip.bin bl2_sd_sec.pbl ddr_fip_sec.bin"

If you assume those names, something should check or enforce this assumption,
which I believe is not a good idea.

Maybe the alternative is to have 2 specific BR2 ATF settings respectively
for bl2_sd_sec.pbl and for ddr_fip_sec.bin.

Best regards,
  Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-11-14  9:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:38 [Buildroot] [PATCH 0/2] NXP Layerscape secure boot support for TF-A Leo Denieul
2026-11-12  9:39 ` [Buildroot] [PATCH 1/2] boot/arm-trusted-firmware: add NXP Layerscape secure boot support Leo Denieul
2026-11-12  9:39 ` [Buildroot] [PATCH 2/2] board/freescale/lx2160a-rdb: add " Leo Denieul
2026-11-14  9:58   ` Vincent Jardin via buildroot [this message]
2026-11-12 10:22 ` [Buildroot] [PATCH 0/2] NXP Layerscape secure boot support for TF-A Leo Denieul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avgw38JrRMWJUIUt@L30177.local \
    --to=buildroot@buildroot.org \
    --cc=geomatsi@gmail.com \
    --cc=hi@senzilla.io \
    --cc=leo.denieul.yoshino@gmail.com \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.