Re: [PATCH v1] checkpatch: Add context-analysis attributes

[Vincent Donnefort <vdonnefort@google.com>]

On Thu, Nov 12, 2026 at 07:32:14PM -0800, Joe Perches wrote:
> On Thu, 2026-11-12 at 15:12 +0000, Vincent Donnefort wrote:
> > Checkpatch doesn't know about the context analysis attributes and
> > misparses annotated declarations (e.g. mistaking __guarded_by() fields
> > for extern prototype). Add them to the known attributes list.
> 
> Nak.
> 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -526,6 +526,25 @@ our $InitAttributeData = qr{$InitAttributePrefix(?:initdata\b)};
> >  our $InitAttributeConst = qr{$InitAttributePrefix(?:initconst\b)};
> >  our $InitAttributeInit = qr{$InitAttributePrefix(?:init\b)};
> >  our $InitAttribute = qr{$InitAttributeData|$InitAttributeConst|$InitAttributeInit};
> > +our $ContextAnalysis = qr{
> 
> Are all of these from include/linux/compiler-context-analysis.h ?

Correct, except __rcu_guarded, which I can drop.

> 
> > +			__guarded_by\b|
> 
> __guarded_by takes an argument so it should be
> 
> 			__guarded_by\s*\(.*\)
> 
> like the __aligned use below in $Attribute
> 
> > +			__pt_guarded_by\b|
> 
> And all the rest of these entries that take arguments need to add
> that same '\s*\(.*\)'
> 
> and it'll be fragile besides, multiline uses likely won't work,
> any use that has another internal () pair won't work, etc...

How about matching one internal () pair?

__guarded_by\s*\(
	(?:
		[^()]++ |
		\([^()]*+\)
	)*+
\)

This would at least cover all existing declarations.

-- 
Vincent

> 
> > +			__rcu_guarded\b|
> > +			__must_hold\b|
> > +			__must_hold_shared\b|
> > +			__must_not_hold\b|
> > +			__acquires\b|
> > +			__acquires_shared\b|
> > +			__cond_acquires\b|
> > +			__cond_acquires_shared\b|
> > +			__releases\b|
> > +			__releases_shared\b|
> > +			__cond_releases\b|
> > +			__no_context_analysis\b|
> > +			__context_unsafe\b|
> > +			__acquires_ret\b|
> > +			__acquires_shared_ret\b
> > +		}x;
> >  
> >  # Notes to $Attribute:
> >  # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
> > @@ -551,6 +570,7 @@ our $Attribute	= qr{
> >  			__ro_after_init|
> >  			__kprobes|
> >  			$InitAttribute|
> > +			$ContextAnalysis|
> >  			__aligned\s*\(.*\)|
> >  			____cacheline_aligned|
> >  			____cacheline_aligned_in_smp|
> > 
> > base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4