Re: [PATCH v6 12/19] string: Remove strstarts()

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

> Date: 2026-11-14 15:29:50+0000
> From: sashiko-bot@kernel.org
>
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] string: removing strstarts() breaks build in
>   xe_sysctrl_mailbox_write()
> --
> 
> commit e1746880c54dd32f27fc7343468741cdc4b05246
> Author: Alejandro Colomar <alx@kernel.org>
> 
> string: Remove strstarts()
> 
> This commit removes the legacy strstarts() macro alias for strprefix() from
> include/linux/string.h.
> 
> > diff --git a/include/linux/string.h b/include/linux/string.h
> > index 0a466360dbb39..6b0de932e23a8 100644
> > --- a/include/linux/string.h
> > +++ b/include/linux/string.h
> > @@ -609,7 +609,6 @@ static inline const char *strprefix(const char *s, const char *prefix)
> >  	return strncmp(s, prefix, len) == 0 ? s + len : NULL;
> >  }
> >  #define strprefix(s, pfx)  const_cast(CQChar_of(s) *, strprefix(s, pfx))
> > -#define strstarts(s, pfx)  strprefix(s, pfx)  // legacy alias
> 
> [Severity: High]
> Does removing strstarts() break the build when CONFIG_DRM_XE is enabled?
> drivers/gpu/drm/xe/xe_sysctrl_debugfs.c:xe_sysctrl_mailbox_write() still

What?!  I don't see this file or function.

	$ ls drivers/gpu/drm/xe/xe_sysctrl_debugfs.c;
	ls: cannot access 'drivers/gpu/drm/xe/xe_sysctrl_debugfs.c': No such file or directory
	$ git ls-files | grep '\.[ch]$' | xargs grep xe_sysctrl_mailbox_write;
	$

> calls strstarts(token, "timeout=") and strstarts(token, "resplen="), which
> now fail with an implicit function declaration error.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794667407.git.alx@kernel.org?part=12

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]