From: Florian Westphal <fw@strlen.de>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ipset] tests: hash:net,iface.t: add test case for wildcard matching behaviour
Date: Sun, 15 Nov 2026 19:21:28 +0100 [thread overview]
Message-ID: <avn4KIth2ics2YkS@strlen.de> (raw)
In-Reply-To: <86662718-9117-5c82-cd2e-74298a9a2c7f@netfilter.org>
Jozsef Kadlecsik <kadlec@netfilter.org> wrote:
> > +# Delete the specific entry.
> > +0 ipset del test 10.0.1.0/24,eth0
> > +# The wildcard entry should still be there and match eth1 via its prefix.
> > +0 ipset test test 10.0.1.0/24,eth1
>
> The original code does not handle the case properly and the wildcard entry
> can be deleted instead the specific one. If it passes for you then it's
> just lucky ordering.
Yes, it passes both on main and rhashtable_v10.
> > +# eth0 is excluded by the nomatch entry; it must not match via the wildcard.
> > +1 ipset test test 10.0.3.0/24,eth0
> > +0 ipset destroy test
>
> This part also does not handled properly with the current code: it lacks
> the ordering to match/delete first the specific and then the wildcard
> records.
Lucky coincidence, then?
What do we do now? Will you make test cases that demonstrate the
expected behaviour and I respin a v11 that passes those tests?
next prev parent reply other threads:[~2026-11-15 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:02 [PATCH ipset] tests: hash:net,iface.t: add test case for wildcard matching behaviour Florian Westphal
2026-11-15 16:39 ` Jozsef Kadlecsik
2026-11-15 18:21 ` Florian Westphal [this message]
2026-11-17 16:26 ` Jozsef Kadlecsik
2026-11-17 17:10 ` Florian Westphal
2026-11-15 16:45 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avn4KIth2ics2YkS@strlen.de \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.