All of lore.kernel.org
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Ewout ter Hoeven <ewoutterhoeven@live.nl>
Cc: Matt Stark <msta@google.com>,
	git@vger.kernel.org, ps@pks.im, gitster@pobox.com,
	phillip.wood@dunelm.org.uk,
	Martin von Zweigbergk <martinvonz@google.com>,
	remo@buenzli.dev, Edwin Kempin <ekempin@google.com>,
	schacon@gmail.com, philipmetzger@bluewin.ch,
	konstantin@linuxfoundation.org, newren@gmail.com, tytso@mit.edu,
	nico@cryptonector.com, rikingcoding@gmail.com
Subject: Re: [PATCH] headers: Preserve 'change-id' header in rebase / cherry-pick.
Date: Sun, 15 Nov 2026 16:24:24 +0000	[thread overview]
Message-ID: <avnct0KGKN3a76lB@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <GV4P192MB328727D81CAED2956E2C682BC07D2@GV4P192MB3287.EURP192.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On 2026-11-15 at 11:03:05, Ewout ter Hoeven wrote:
> On 2026-04-07 at 23:28, brian m. carlson wrote:
> > Absent some well-defined documentation describing what it means, I don't
> > see how it could provide good value.
> 
> A concrete use case could be stacked pull/merge requests.
> 
> GitHub's stacked PRs (CLI in github/gh-stack) and GitLab's experimental
> "glab stack" both have to answer "is this rewritten commit the same
> change as before?" after every rebase. Without an identity that
> survives rewrites they guess from branch names, recorded bases and
> patch IDs, and the guesses fail in practice:

I don't think that's going to be helpful there.  Users can modify
change-id headers in commits, so they can't be trusted as a source of
unmodified data.  Only if the server does the rebase can it have
confidence that things haven't changed.

Otherwise, a malicious user could get a review on v1 of a series and
send out a completely different v2 with the same change-ids such that
the server would honour the existing review and accept the malicious
code.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA
Speaking for myself only

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]

      reply	other threads:[~2026-11-15 16:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  3:13 [PATCH] headers: Preserve 'change-id' header in rebase / cherry-pick Matt Stark
2026-04-07  4:09 ` Junio C Hamano
2026-04-07  4:58   ` Nico Williams
2026-04-07  5:02     ` Nico Williams
2026-04-07 14:33       ` Junio C Hamano
2026-04-07  9:55     ` Phillip Wood
2026-04-07 15:52       ` Nico Williams
2026-04-07 16:20         ` Junio C Hamano
2026-04-07 20:13           ` Nico Williams
2026-04-07 14:42     ` Junio C Hamano
2026-04-07  9:41   ` Phillip Wood
2026-04-07 23:28 ` brian m. carlson
2026-11-15 11:03   ` Ewout ter Hoeven
2026-11-15 16:24     ` brian m. carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avnct0KGKN3a76lB@fruit.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=ekempin@google.com \
    --cc=ewoutterhoeven@live.nl \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=martinvonz@google.com \
    --cc=msta@google.com \
    --cc=newren@gmail.com \
    --cc=nico@cryptonector.com \
    --cc=philipmetzger@bluewin.ch \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    --cc=remo@buenzli.dev \
    --cc=rikingcoding@gmail.com \
    --cc=schacon@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.