From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Christian Loehle <christian.loehle@arm.com>,
Lee Jones <lee@kernel.org>, Ulf Hansson <ulfh@kernel.org>,
Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>,
Abel Vesa <abelvesa@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Sudeep Holla <sudeep.holla@kernel.org>,
Andy Yan <andyshrk@163.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Andre Draszik <andre.draszik@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Srinivas Kandagatla <srini@kernel.org>,
Ulf Hansson <ulf.hansson@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v27 06/10] power: reset: Add psci-reboot-mode driver
Date: Mon, 16 Nov 2026 00:08:05 +0100 [thread overview]
Message-ID: <avo65hxiVDxpJRn-@venus> (raw)
In-Reply-To: <20261029-arm-psci-system_reset2-vendor-reboots-v27-6-fa4b3ff1359b@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 7666 bytes --]
Hi,
On Thu, Oct 29, 2026 at 02:31:00PM +0530, Shivendra Pratap wrote:
> PSCI supports different types of resets like SYSTEM_RESET, SYSTEM_RESET2
> ARCH WARM reset and SYSTEM_RESET2 vendor-specific resets. Currently
> there is no common driver that handles all supported psci resets at one
> place. Additionally, there is no common mechanism to issue the supported
> psci resets from userspace.
>
> Add psci-reboot-mode as an auxiliary device created by the psci-devices
> driver. Define two types of PSCI resets, predefined-resets and
> vendor-specific resets. Predefined-resets are defined by psci driver
> and vendor-specific resets are defined by SoC vendors, under the
> psci:reboot-mode node of SoC device tree.
>
> Register the driver with the reboot-mode framework to interface these
> resets to userspace. When userspace initiates a supported command, pass
> the reset arguments to the PSCI driver to enable command-based reset.
>
> This change allows userspace to issue supported PSCI reset commands
> using the standard reboot system calls while enabling SoC vendors to
> define their specific resets for PSCI.
>
> Suggested-by: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
> Suggested-by: Lee Jones <lee@kernel.org>
> Suggested-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> ---
> MAINTAINERS | 1 +
> drivers/firmware/psci/psci-devices.c | 4 ++
> drivers/power/reset/Kconfig | 11 ++++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/psci-reboot-mode.c | 101 +++++++++++++++++++++++++++++++++
> 5 files changed, 118 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e4ca41cdd872..0e03826eec48 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22292,6 +22292,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> F: Documentation/devicetree/bindings/arm/psci.yaml
> F: drivers/firmware/psci/
> +F: drivers/power/reset/psci-reboot-mode.c
> F: include/linux/psci.h
> F: include/uapi/linux/psci.h
>
> diff --git a/drivers/firmware/psci/psci-devices.c b/drivers/firmware/psci/psci-devices.c
> index d23befc490ed..04f24b8d9943 100644
> --- a/drivers/firmware/psci/psci-devices.c
> +++ b/drivers/firmware/psci/psci-devices.c
> @@ -20,6 +20,10 @@ static const struct arm_psci_device_info arm_psci_devices[] = {
> {
> .name = "psci-cpuidle-domain",
> },
> + {
> + .name = "psci-reboot-mode",
> + .of_node_name = "reboot-mode",
> + },
> };
>
> static void arm_psci_auxiliary_device_release(struct device *dev)
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index bce996bbef28..f165a41d40ed 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -360,6 +360,17 @@ config NVMEM_REBOOT_MODE
> then the bootloader can read it and take different
> action according to the mode.
>
> +config PSCI_REBOOT_MODE
> + bool "PSCI reboot mode driver"
> + depends on ARM_PSCI_DEVICES
> + select AUXILIARY_BUS
> + select REBOOT_MODE
> + help
> + Say y here to enable the PSCI reboot mode driver. The driver
> + registers with the reboot-mode framework to configure PSCI
> + reset commands, which are executed by the PSCI driver during
> + psci_sys_reset().
> +
> config POWER_MLXBF
> tristate "Mellanox BlueField power handling driver"
> depends on (GPIO_MLXBF2 || GPIO_MLXBF3) && ACPI
> diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
> index e31cab4ba78e..45d8aaaffaa1 100644
> --- a/drivers/power/reset/Makefile
> +++ b/drivers/power/reset/Makefile
> @@ -41,5 +41,6 @@ obj-$(CONFIG_REBOOT_MODE) += reboot-mode.o
> obj-$(CONFIG_SYSCON_REBOOT_MODE) += syscon-reboot-mode.o
> obj-$(CONFIG_POWER_RESET_SC27XX) += sc27xx-poweroff.o
> obj-$(CONFIG_NVMEM_REBOOT_MODE) += nvmem-reboot-mode.o
> +obj-$(CONFIG_PSCI_REBOOT_MODE) += psci-reboot-mode.o
> obj-$(CONFIG_POWER_MLXBF) += pwr-mlxbf.o
> obj-$(CONFIG_POWER_RESET_QEMU_VIRT_CTRL) += qemu-virt-ctrl.o
> diff --git a/drivers/power/reset/psci-reboot-mode.c b/drivers/power/reset/psci-reboot-mode.c
> new file mode 100644
> index 000000000000..c5dcfc40392a
> --- /dev/null
> +++ b/drivers/power/reset/psci-reboot-mode.c
> @@ -0,0 +1,101 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <linux/array_size.h>
> +#include <linux/auxiliary_bus.h>
> +#include <linux/device.h>
> +#include <linux/module.h>
> +#include <linux/psci.h>
> +#include <linux/reboot-mode.h>
> +#include <linux/slab.h>
> +#include <linux/types.h>
> +
> +/*
> + * Predefined modes use two arguments. arg1/magic[0] is always zero and
> + * arg2/magic[1] is one of the values defined by enum psci_standard_resets.
> + */
> +static const struct reboot_mode_entry psci_resets[] = {
> + {
> + .name = "psci-system-reset",
> + .magic = { 0, PSCI_SYSTEM_RESET_COLD_RESET },
> + .count = 2,
> + },
> + {
> + .name = "psci-system-reset2-arch-warm-reset",
> + .magic = { 0, PSCI_SYSTEM_RESET2_ARCH_WARM_RESET },
> + .count = 2,
> + },
> +};
> +
> +static u64 psci_reboot_mode_get_cookie(const u32 *magic, int count)
> +{
> + u64 cookie = 0;
> + int i;
> +
> + /*
> + * For a 3-cell magic, arg2 is the high 32 bits and arg3 is the low 32 bits.
> + * For a 2-cell magic, arg2 is the low 32 bits.
> + */
> + for (i = 1; i < count; i++)
> + cookie = (cookie << 32) | magic[i];
> +
> + return cookie;
> +}
> +
> +static int psci_reboot_mode_write(struct reboot_mode_driver *reboot,
> + const u32 *magic, u32 count)
> +{
> + if (count < 2 || count > 3)
> + return -EINVAL;
> +
> + /* Unexpected value at magic[1]/arg2 on a 32-bit system. */
> + if (!IS_ENABLED(CONFIG_64BIT) && count == 3 && magic[1])
> + return -EINVAL;
> +
> + return psci_set_reset_cmd(magic[0],
> + psci_reboot_mode_get_cookie(magic, count));
> +}
> +
> +static int psci_reboot_mode_probe(struct auxiliary_device *auxdev,
> + const struct auxiliary_device_id *id)
> +{
> + struct reboot_mode_driver *reboot;
> + struct device *dev = &auxdev->dev;
> + size_t count;
> + int ret;
> +
> + reboot = devm_kzalloc(dev, sizeof(*reboot), GFP_KERNEL);
> + if (!reboot)
> + return -ENOMEM;
reboot = devm_kzalloc_obj(dev, *reboot);
Otherwise:
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> + /* Skip PSCI SYSTEM_RESET2 modes if unsupported. */
> + count = psci_has_system_reset2_support() ? ARRAY_SIZE(psci_resets) : 1;
> +
> + ret = reboot_mode_driver_init(reboot, dev, NULL,
> + psci_reboot_mode_write, psci_resets,
> + count);
> + if (ret)
> + return ret;
> +
> + return devm_reboot_mode_register(dev, reboot);
> +}
> +
> +static const struct auxiliary_device_id psci_reboot_mode_id_table[] = {
> + { .name = "arm-psci.psci-reboot-mode" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(auxiliary, psci_reboot_mode_id_table);
> +
> +static struct auxiliary_driver psci_reboot_mode_driver = {
> + .probe = psci_reboot_mode_probe,
> + .id_table = psci_reboot_mode_id_table,
> +};
> +
> +static int __init psci_reboot_mode_init(void)
> +{
> + return __auxiliary_driver_register(&psci_reboot_mode_driver, THIS_MODULE,
> + "psci-reboot-mode");
> +}
> +subsys_initcall(psci_reboot_mode_init);
>
> --
> 2.34.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-11-16 6:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 9:00 [PATCH v27 00/10] Implement PSCI reboot mode driver for PSCI resets Shivendra Pratap
2026-10-29 9:00 ` [PATCH v27 01/10] power: reset: reboot-mode: Support up to 3 magic values per mode Shivendra Pratap
2026-11-15 23:08 ` Sebastian Reichel
2026-10-29 9:00 ` [PATCH v27 02/10] power: reset: reboot-mode: Add support for predefined reboot modes Shivendra Pratap
2026-10-29 9:23 ` sashiko-bot
2026-11-15 23:13 ` Sebastian Reichel
2026-10-29 9:00 ` [PATCH v27 03/10] firmware: psci: Introduce command-based resets Shivendra Pratap
2026-10-29 9:00 ` [PATCH v27 04/10] firmware: psci: Add support for PSCI auxiliary devices Shivendra Pratap
2026-10-29 10:00 ` sashiko-bot
2026-10-29 9:00 ` [PATCH v27 05/10] dt-bindings: arm: Document reboot mode magic Shivendra Pratap
2026-11-02 9:40 ` Bartosz Golaszewski
2026-11-17 13:45 ` Bartosz Golaszewski
2026-10-29 9:01 ` [PATCH v27 06/10] power: reset: Add psci-reboot-mode driver Shivendra Pratap
2026-11-15 23:08 ` Sebastian Reichel [this message]
2026-10-29 9:01 ` [PATCH v27 07/10] arm64: dts: qcom: Add psci reboot-modes for kodiak boards Shivendra Pratap
2026-10-29 10:23 ` Abel Vesa
2026-10-29 9:01 ` [PATCH v27 08/10] arm64: dts: qcom: Add psci reboot-modes for lemans boards Shivendra Pratap
2026-10-29 10:23 ` Abel Vesa
2026-10-29 9:01 ` [PATCH v27 09/10] arm64: dts: qcom: Add psci reboot-modes for monaco boards Shivendra Pratap
2026-10-29 10:24 ` Abel Vesa
2026-10-29 9:01 ` [PATCH v27 10/10] arm64: dts: qcom: Add psci reboot-modes for talos boards Shivendra Pratap
2026-10-29 10:24 ` Abel Vesa
2026-11-09 15:47 ` [PATCH v27 00/10] Implement PSCI reboot mode driver for PSCI resets Ulf Hansson
2026-11-15 23:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avo65hxiVDxpJRn-@venus \
--to=sebastian.reichel@collabora.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=andyshrk@163.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=christian.loehle@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=moritz.fischer@ettus.com \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=shivendra.pratap@oss.qualcomm.com \
--cc=srini@kernel.org \
--cc=sudeep.holla@kernel.org \
--cc=ulf.hansson@oss.qualcomm.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.