All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fuchs <fuchsfl@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: arch/sh/include/asm/uaccess_32.h:204:1: error: impossible constraint in 'asm'
Date: Sun, 15 Nov 2026 23:05:11 +0100	[thread overview]
Message-ID: <avosl5rcgpWCw0Ur@lithos> (raw)
In-Reply-To: <202611151925.SgXid5Fj-lkp@intel.com>

Hi Adrian,

On 15 Nov 19:44, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   23c62304dde29abe92013d85910d03a77dada35d
> commit: 8b5dba9ea4a3f5ed994f03d6ca7686c49491b426 sh: uaccess: Require offsettable operands for 64-bit user access
> date:   6 weeks ago
> config: sh-randconfig-r2311-20261115 (https://download.01.org/0day-ci/archive/20261115/202611151925.SgXid5Fj-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 9.5.0
> sparse: v0.6.5-rc1-21-g84ec0658
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261115/202611151925.SgXid5Fj-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Fixes: 8b5dba9ea4a3 ("sh: uaccess: Require offsettable operands for 64-bit user access")
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611151925.SgXid5Fj-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/export.h:5,
>                     from drivers/gpu/drm/drm_property.c:23:
>    drivers/gpu/drm/drm_property.c: In function 'drm_mode_getproperty_ioctl':
> >> arch/sh/include/asm/uaccess_32.h:204:1: error: impossible constraint in 'asm'
>      203 | ({ \
>          | ~~~~
>      204 | __asm__ __volatile__( \
>          | ^~~~~~~~~~~~~~~~~~~~~~~
>      205 |  "1:\n\t" \
>          |  ~~~~~~~~~~
>      206 |  "mov.l %S1,%2\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~~
>      207 |  "mov.l %R1,%T2\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~~~
>      208 |  "2:\n" \
>          |  ~~~~~~~~
>      209 |  ".section .fixup,\"ax\"\n" \
>          |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      210 |  "3:\n\t" \
>          |  ~~~~~~~~~~
>      211 |  "mov.l 4f,%0\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~
>      212 |  "jmp @%0\n\t" \
>          |  ~~~~~~~~~~~~~~~
>      213 |  " mov %3,%0\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~
>      214 |  ".balign 4\n" \
>          |  ~~~~~~~~~~~~~~~
>      215 |  "4: .long 2b\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~
>      216 |  ".previous\n" \
>          |  ~~~~~~~~~~~~~~~
>      217 |  ".section __ex_table,\"a\"\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      218 |  ".long 1b, 3b\n\t" \
>          |  ~~~~~~~~~~~~~~~~~~~~
>      219 |  ".previous" \
>          |  ~~~~~~~~~~~~~
>      220 |  : "=r" (retval) \
>          |  ~~~~~~~~~~~~~~~~~
>      221 |  : "r" (val), "o" (__m(addr)), "i" (-EFAULT), "0" (retval) \
>          |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      222 |         : "memory"); })
>          |         ~~~~~~~~~~~~~~~
>    include/linux/compiler.h:68:3: note: in definition of macro '__trace_if_value'
>       68 |  (cond) ?     \
>          |   ^~~~
>    include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
>       55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>          |                            ^~~~~~~~~~~~~~
>    drivers/gpu/drm/drm_property.c:484:3: note: in expansion of macro 'if'
>      484 |   if (i < out_resp->count_values &&
>          |   ^~
>    arch/sh/include/asm/uaccess_32.h:136:3: note: in expansion of macro '__put_user_u64'
>      136 |   __put_user_u64(x, ptr, retval);  \
>          |   ^~~~~~~~~~~~~~
>    arch/sh/include/asm/uaccess.h:72:3: note: in expansion of macro '__put_user_size'
>       72 |   __put_user_size(__pu_val, __pu_addr, (size), \
>          |   ^~~~~~~~~~~~~~~
>    arch/sh/include/asm/uaccess.h:20:26: note: in expansion of macro '__put_user_check'
>       20 | #define put_user(x,ptr)  __put_user_check((x), (ptr), sizeof(*(ptr)))
>          |                          ^~~~~~~~~~~~~~~~
>    drivers/gpu/drm/drm_property.c:485:7: note: in expansion of macro 'put_user'
>      485 |       put_user(property->values[i], values_ptr + i)) {
>          |       ^~~~~~~~
> 
> 
> vim +/asm +204 arch/sh/include/asm/uaccess_32.h
> 
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  178  
> 0fb19dcb64ec4b include/asm-sh/uaccess_32.h      Stuart Menefy 2007-11-30  179  #if defined(CONFIG_CPU_LITTLE_ENDIAN)
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  180  #define __put_user_u64(val,addr,retval) \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  181  ({ \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  182  __asm__ __volatile__( \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  183  	"1:\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  184  	"mov.l	%R1,%2\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  185  	"mov.l	%S1,%T2\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  186  	"2:\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  187  	".section	.fixup,\"ax\"\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  188  	"3:\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  189  	"mov.l	4f,%0\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  190  	"jmp	@%0\n\t" \
> 0fb19dcb64ec4b include/asm-sh/uaccess_32.h      Stuart Menefy 2007-11-30  191  	" mov	%3,%0\n\t" \
> 0fb19dcb64ec4b include/asm-sh/uaccess_32.h      Stuart Menefy 2007-11-30  192  	".balign	4\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  193  	"4:	.long	2b\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  194  	".previous\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  195  	".section	__ex_table,\"a\"\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  196  	".long	1b, 3b\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  197  	".previous" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  198  	: "=r" (retval) \
> 8b5dba9ea4a3f5 arch/sh/include/asm/uaccess_32.h Florian Fuchs 2026-07-16  199  	: "r" (val), "o" (__m(addr)), "i" (-EFAULT), "0" (retval) \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  200          : "memory"); })
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  201  #else
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  202  #define __put_user_u64(val,addr,retval) \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  203  ({ \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10 @204  __asm__ __volatile__( \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  205  	"1:\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  206  	"mov.l	%S1,%2\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  207  	"mov.l	%R1,%T2\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  208  	"2:\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  209  	".section	.fixup,\"ax\"\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  210  	"3:\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  211  	"mov.l	4f,%0\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  212  	"jmp	@%0\n\t" \
> 0fb19dcb64ec4b include/asm-sh/uaccess_32.h      Stuart Menefy 2007-11-30  213  	" mov	%3,%0\n\t" \
> 0fb19dcb64ec4b include/asm-sh/uaccess_32.h      Stuart Menefy 2007-11-30  214  	".balign	4\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  215  	"4:	.long	2b\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  216  	".previous\n" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  217  	".section	__ex_table,\"a\"\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  218  	".long	1b, 3b\n\t" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  219  	".previous" \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  220  	: "=r" (retval) \
> 8b5dba9ea4a3f5 arch/sh/include/asm/uaccess_32.h Florian Fuchs 2026-07-16  221  	: "r" (val), "o" (__m(addr)), "i" (-EFAULT), "0" (retval) \
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  222          : "memory"); })
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  223  #endif
> 9b01bd9ee64088 include/asm-sh/uaccess_32.h      Paul Mundt    2007-11-10  224  
> 
> :::::: The code at line 204 was first introduced by commit
> :::::: 9b01bd9ee6408846c0553c03fb4b864353a845c9 sh: Split out uaccess.h in to _32 and _64 variants.
> 
> :::::: TO: Paul Mundt <lethal@linux-sh.org>
> :::::: CC: Paul Mundt <lethal@linux-sh.org>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

with the commit 8b5dba9ea4a3 ("sh: uaccess: Require offsettable operands
for 64-bit user access") reverted, the test results in a gcc ICE in
change_address_1, which was the initial reason for the fix.
So the "o" fix from the commit does fix some cases, but doesn't prevent
every case of a non-offsetable address to reach the asm.
I think we could fully fix it, by passing the address in a register, but
I need to dig more into that.

So it is not a new issue, but caused by the same root problem. The cases
that previously triggered an ICE give now sometimes a compiler error.

Regards
Florian

      reply	other threads:[~2026-11-15 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 18:44 arch/sh/include/asm/uaccess_32.h:204:1: error: impossible constraint in 'asm' kernel test robot
2026-11-15 22:05 ` Florian Fuchs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avosl5rcgpWCw0Ur@lithos \
    --to=fuchsfl@gmail.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.