From: Hangbin Liu <hangbin.liu@linux.dev>
To: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
Cc: netdev@vger.kernel.org, po-hsu.lin@canonical.com,
linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure
Date: Mon, 16 Nov 2026 08:58:49 +0800 [thread overview]
Message-ID: <avpVSd7XV1lIOeZf@fedora> (raw)
In-Reply-To: <20261115222351.52930-1-emmaonana18@gmail.com>
On Sun, Nov 15, 2026 at 11:23:51PM +0100, Omokefe Emmanuel Onanaroghene wrote:
> run_arp_evict_nocarrier_disabled_all() reports mismatches with a
> "failed" line but never sets ret, so the script exits 0 even when the
> all.arp_evict_nocarrier=0 test fails. The 2023 bulk fix wired the
> other five test functions and missed this one; the v6 twin
> (run_ndisc_evict_nocarrier_disabled_all) already sets ret=1. Set
> ret=1 on mismatch.
>
> Fixes: 1856628baa170 ("selftests: net: return non-zero for failures reported in arp_ndisc_evict_nocarrier")
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
> ---
> tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> index 00758f00efbfa..4afb953a3e479 100755
> --- a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> +++ b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> @@ -139,6 +139,7 @@ run_arp_evict_nocarrier_disabled_all() {
> echo "ok"
> else
> echo "failed"
> + ret=1
> fi
>
> cleanup_v4
> --
> 2.43.0
>
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
prev parent reply other threads:[~2026-11-16 0:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 22:23 [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure Omokefe Emmanuel Onanaroghene
2026-11-16 0:58 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avpVSd7XV1lIOeZf@fedora \
--to=hangbin.liu@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=emmaonana18@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=po-hsu.lin@canonical.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.