From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hongyan Xu <getshell@seu.edu.cn>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] Input: lm8323 - drain PWM work and finish with outputs disabled
Date: Sun, 15 Nov 2026 18:36:50 -0800 [thread overview]
Message-ID: <avpr6qngp8rfJ9Fe@google.com> (raw)
In-Reply-To: <179474329214.103840.17616107855531843241@seu.edu.cn>
Hi Hongyan,
On Sun, Nov 15, 2026 at 07:48:12PM +0800, Hongyan Xu wrote:
> A PWM brightness callback can leave private work pending when the
> managed LED and chip state are released. Merely cancelling that
> work also discards the final LED_OFF requested by LED unregister.
> Flushing alone is insufficient if an earlier fade is still
> running: the worker waits for an IRQ to requeue it, and the
> managed IRQ is released before the LEDs during teardown.
>
> Install cleanup before registering each LED. Once LED unregister
> and IRQ teardown have stopped the producers, cancel its work and
> use the documented single-END shutdown sequence: put END with
> RESET set in unused script slot 59, stop the channel and restart
> at that slot. Do not overwrite a running brightness script. The
> engine then disables its output autonomously without another IRQ
> or a worker accessing freed driver data. A current long RAMP can
> delay completion, as documented by the device specification.
>
> Found by the author's in-house static analysis tool.
>
> Fixes: a48b2d4a0091 ("Input: introduce lm8323 keypad driver")
This driver is being removed, no need to patch it.
Thanks.
--
Dmitry
prev parent reply other threads:[~2026-11-16 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 11:48 [PATCH v2] Input: lm8323 - drain PWM work and finish with outputs disabled Hongyan Xu
2026-11-16 2:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avpr6qngp8rfJ9Fe@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=getshell@seu.edu.cn \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.