From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Brigham Campbell <me@brighamcampbell.com>
Cc: "Jean Delvare" <jdelvare@suse.de>,
linux-i2c@vger.kernel.org,
"Gero Schwäricke" <gero.schwaericke@sevenlab.de>
Subject: Re: [PATCH v5 1/2] i2c-tools: Allow passing device file paths
Date: Mon, 16 Nov 2026 09:00:05 +0100 [thread overview]
Message-ID: <avq4AIoI-3T8P6tJ@shikoro> (raw)
In-Reply-To: <DMWGDZA99U2V.ZHHILKEL821X@brighamcampbell.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Brigham,
> Finally getting back to you after a good friend's wedding.
Nice! Hope you had a great time.
> Printing an error instead of trying to parse the argument as a name or
> path is an undercommitment on the part of the user interface. It makes
> breaking changes to that 0xFFFFF boundary easier. When we increase the
> boundary size, we don't need to worry about users passing
> (PREVIOUS_BOUNDARY + 1) and expecting it to be interpreted as a bus name
> or device file path.
>
> Even if we know the boundary will never change, I think it would be
> better if users can always expect unsigned long values to be interpreted
> as bus numbers directly, even if too-big values always result in an
> error.
Good argument, I am convinced. I will apply v5 as is now.
Thank you for all the work on this!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-11-16 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 8:52 [PATCH v5 0/2] i2c-tools: Make tools accept bus path Brigham Campbell
2026-07-22 8:52 ` [PATCH v5 1/2] i2c-tools: Allow passing device file paths Brigham Campbell
2026-11-08 13:09 ` Wolfram Sang
2026-11-15 22:34 ` Wolfram Sang
2026-11-16 7:23 ` Brigham Campbell
2026-11-16 8:00 ` Wolfram Sang [this message]
2026-07-22 8:52 ` [PATCH v5 2/2] i2c-tools: Document device paths as I2CBUS arg Brigham Campbell
2026-09-07 21:18 ` [PATCH v5 0/2] i2c-tools: Make tools accept bus path Brigham Campbell
2026-09-27 16:02 ` Wolfram Sang
2026-10-04 2:57 ` Brigham Campbell
2026-11-16 8:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avq4AIoI-3T8P6tJ@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=gero.schwaericke@sevenlab.de \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=me@brighamcampbell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.