All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Haowen Tu <tuhaowen@uniontech.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: max77693-haptic - disable bias on failed open
Date: Sun, 15 Nov 2026 23:24:00 -0800	[thread overview]
Message-ID: <avqvjEZfFOzvRdXe@google.com> (raw)
In-Reply-To: <98F5ACA9EADBEC89+20261116022442.3298673-1-tuhaowen@uniontech.com>

On Mon, Nov 16, 2026 at 10:24:42AM +0800, Haowen Tu wrote:
> max77693_haptic_open() enables the MAX77843 bias before enabling the motor
> regulator. If regulator_enable() fails, the function returns without
> turning the bias off. The input core does not call the close callback
> after a failed open, so its bias cleanup does not run either.
> 
> Disable the bias before returning the regulator error. The bias helper
> already handles reporting register access errors and is a no-op for the
> other supported chip variants.
> 
> Fixes: 56bbc99e6914 ("Input: max77693: Add support for Maxim 77843")
> Signed-off-by: Haowen Tu <tuhaowen@uniontech.com>

Applied, thank you.

-- 
Dmitry

      reply	other threads:[~2026-11-16  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  2:24 [PATCH] Input: max77693-haptic - disable bias on failed open Haowen Tu
2026-11-16  7:24 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avqvjEZfFOzvRdXe@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tuhaowen@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.