From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.225.73 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794820940; b=zhJsnv6IO/2KvS881a66xYVPx6KcE0xng+Q6f8Dsn7RnwnqaJ3rIK4/QV8oLJDwjKrRy bJ70chMD/VHInRZlteb/fzMNkimuj80EnvkK63BQvEIpn15HGS6JQ/yRoXk/U37OhAkQc 8GaKg5KJBj9mRplc7QnX5n/AhfG3eqhgEDZhSHTHfPoPPJSy9e64BKVk1AvZPftCbVTFP CY9AN+zr/lKXTrMHv8x/Fxi9KQH9Z2p9zHxNsXqhm1F7QbA1oeGlT7bQhU7XkRd1saT/p nInGvATIApIAbOmT+Gm6boHLt9LY7XHN0kaVKJgdL6UDl+HI2wq0WVitMQ0jOr0nA+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794820940; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=kHdIL6Qy/M97X4vCAX1fCvBa1y4VV/EfPvmnoDmBPuA=; b=OCUpstBprDcbrdUe1yU4gklqafUW5KsCJzfu+64YNGltUNkUz3IbdTr8urlsDJdiNJzZ MHBMj3XUJDBtRDWVXd/Flv+OguGWOKbzP/rbVvs9LPUoyqicu0SVORoZoPq1FWaXmL5k2 /EgsSjf8BLEY/fCWvwrCRfk6MWaTk2D8b8kTJ4PVYMbGI4E98R6YQMEhQ6cVF76mqPFfw RlMgDLGACgp+VmijpXEV/nudUwuzgA1kZsiJmePQCZxH1TJFcNE5S7s6Eph/yF0l93wrd SqimJRLvZLOaT5uUCxFC+vbIEQRRCtLJfo+wZAiILaHm7Wtzmbw/XzM94+Y+g4uvOFA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=pereq.eu; spf=pass smtp.mailfrom=cryspen.com; dkim=pass header.d=pereq.eu header.i=@pereq.eu header.a=rsa-sha256 header.s=google header.b=V1mA2Rq8; arc=none smtp.remote-ip=74.125.225.73 Received: from mail-wr2-f9.google.com (mail-wr2-f9.google.com [74.125.225.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95568606A329 for ; Mon, 16 Nov 2026 09:22:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 95568606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pereq.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cryspen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=pereq.eu header.i=@pereq.eu header.a=rsa-sha256 header.s=google header.b=V1mA2Rq8 Received: by mail-wr2-f9.google.com with SMTP id ffacd0b85a97d-490ca655ba2so1265270f8f.1 for ; Mon, 16 Nov 2026 01:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pereq.eu; s=google; t=1794820938; x=1795425738; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kHdIL6Qy/M97X4vCAX1fCvBa1y4VV/EfPvmnoDmBPuA=; b=V1mA2Rq8axjd5UuOqShX0+NFFajonLEnP+fODR9etuMbydXolH6adlCFGh1UCGAD11 yS18NWSrC1Fub0gcRXuQ85IqyZKsV9Vhwom4Ej/f7YW0xvD9QciJYrjX56BH9TdqzS8B Le/2s7v/VN3mHZMJH5TCbS3ExdW7gmH6ikVzjeil9WLS3AV4wPoiW5SGul7wVwUIps0p sHPKvTesXDqwQWtc0gdGxNdsv+3aIMFFTy5bIdIqgeHJJGDNdhKzeTR2XO0wjwbGBEMo xK4yrb+OZN/p3QNYMANFyYDctmyJ1dWjXQeOEed2mBaaQx1B4NI7+ywt7b3mL5xCorTA OMJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794820938; x=1795425738; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kHdIL6Qy/M97X4vCAX1fCvBa1y4VV/EfPvmnoDmBPuA=; b=oBpgjV2u6Xxnz0u7JZDFMY4wvcFc1osP92F3ZP6szmotkWGzPGDOD7ye2FBWEY0Id7 KGeW9DkK4ESknmoJu/scKDb9Y/FsJcCAaNrvKVkPWBxYF2SQ/1kJfvN1bEbvENaRn4GM 5gyLNS//wZur4FBuuLoqFl3yZKB5wAz+xvugD49Ayyoqd/B+hQorAn58YjmefDjnyfR5 RewtuBhKnVvXXVm0EgtkxZxBnNXswBfHMbv51Zky756odgpNMwFZQYIPUL7pUwc2YJ3o hJaDtjVVhe/uiBTANendBTsJ3ekaVEi9nHlvBhfsMVZoeOIzPPaVI2unrUK3eIasxMd5 qePA== X-Gm-Message-State: APuU4Z/PcgXtHaPRUBKCEPd9fjaVKmK+slEISuF281Szgr34YnwYD6BI 26OAW4mv9dTS5GH7c/2GX94L7UHFAob6I7tooT+ubhp+7vCuEPZZkouFnkVtXYU1JBU= X-Gm-Gg: AZFdTZf1RZmFAhnzpgDKngUlUwfglXseDuRjRk1BNMKze5YJpnc3Zrz2htuaWZkhHSK TjuaKsiSM9ZhNscP3kzjZ5jQM/2jKI46gUNKVNP/Zg48YFuixOQt6gCh40VnYlvXAHMPakf5lR3 x5SeqWaIgwYkok8xCJbOenEnyy4z0Xi201QbDR61pKpXPcDReAs/cjo2QM41RUb+lqcaZqU+S7/ QKxCuZK5DkCBIYTmm0pq7CE8qV/+QqDZw5mM0XdRVl0F1TZglwqKn+OQUJ8hXXY63gbs51EYI6V +mf0SIc8J6116RVl2R40iMnoAICUrBdcazWU61/oOJsQDROM4sw/4fOB/V082kr4+voD0XVrcO8 2X8/6FwJ2D4eHPtZPiphuyJICgaKUgH6yNw7XhXx3E5CLZb9Wz5GzjPsG1uWkO+fdtX9Qt3o9oZ ONdnYPnWeF2RgyTIWalyuY2DCfTMSBM0Db8O8Vb+pFXD9i46/DQnTtR3k6WriGRTA3mIxQrsh8z P5gggslVxrxSw4GrOUa+EGFygUrZHGgcn7fr0BucJlvG13sFVywY0T74LWtcUwBg72iZHrR7zS2 fvxqd8jjsk33Jpfy+Wg= X-Received: by 2002:a05:6000:260a:b0:48e:5e1f:9a36 with SMTP id ffacd0b85a97d-49c727cf557mr19077157f8f.42.1794820937714; Mon, 16 Nov 2026 01:22:17 -0800 (PST) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c609c651esm21650487f8f.47.2026.11.16.01.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 01:22:17 -0800 (PST) Date: Mon, 16 Nov 2026 12:22:13 +0300 From: Dan Carpenter To: sashiko-reviews@lists.linux.dev Cc: kvmarm@lists.linux.dev, Oliver Upton , Marc Zyngier Subject: Re: [PATCH 1/2] KVM: arm64: nv: Fix AT emulation for TCR2_EL1 Message-ID: References: X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 06:27:41AM +0000, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Medium] KVM: arm64: nv: unmasked PIE/POE in SYS_TCR2 in > __kvm_at_s1e01_fast() and __kvm_at_s1e2() > -- > > commit ba7c962c50af660f734650ef98aa65969755bc0a > Author: Dan Carpenter > > KVM: arm64: nv: Fix AT emulation for TCR2_EL1 > > This commit sanitizes hardware SYS_TCR2 during nested AT instruction > emulation by masking out unsupported PIE and POE bits and clearing > SYS_TCR2 when the guest VM does not support FEAT_TCR2. > > > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > > index 30d8f062b2c29..06765881a4c81 100644 > > --- a/arch/arm64/kvm/at.c > > +++ b/arch/arm64/kvm/at.c > > @@ -1438,7 +1438,13 @@ static u64 __kvm_at_s1e01_fast(struct kvm_vcpu *vcpu, u32 op, u64 vaddr) > > write_sysreg_el1(vcpu_read_sys_reg(vcpu, TCR_EL1), SYS_TCR); > > write_sysreg_el1(vcpu_read_sys_reg(vcpu, MAIR_EL1), SYS_MAIR); > > if (kvm_has_tcr2(vcpu->kvm)) { > > - write_sysreg_el1(vcpu_read_sys_reg(vcpu, TCR2_EL1), SYS_TCR2); > > + u64 tcr2 = effective_tcr2(vcpu, TR_EL10); > > + > > + if (!kvm_has_s1pie(vcpu->kvm)) > > + tcr2 &= ~TCR2_EL1_PIE; > > + if (!kvm_has_s1poe(vcpu->kvm)) > > + tcr2 &= ~(TCR2_EL1_POE | TCR2_EL1_E0POE); > > + write_sysreg_el1(tcr2, SYS_TCR2); > > if (kvm_has_s1pie(vcpu->kvm)) { > > write_sysreg_el1(vcpu_read_sys_reg(vcpu, PIR_EL1), SYS_PIR); > > write_sysreg_el1(vcpu_read_sys_reg(vcpu, PIRE0_EL1), SYS_PIRE0); > > @@ -1452,6 +1458,9 @@ static u64 __kvm_at_s1e01_fast(struct kvm_vcpu *vcpu, u32 op, u64 vaddr) > > __load_stage2(mmu); > > > > skip_mmu_switch: > > + if (cpus_have_final_cap(ARM64_HAS_TCR2) && !kvm_has_tcr2(vcpu->kvm)) > > + write_sysreg_el1(0, SYS_TCR2); > > + > > /* Temporarily switch back to guest context */ > > write_sysreg_hcr(vcpu->arch.hcr_el2); > > isb(); > > @@ -1554,6 +1563,9 @@ int __kvm_at_s1e2(struct kvm_vcpu *vcpu, u32 op, u64 vaddr) > > if (!vcpu_el2_e2h_is_set(vcpu)) > > val |= HCR_EL2_NV | HCR_EL2_NV1; > > > > + if (cpus_have_final_cap(ARM64_HAS_TCR2) && !kvm_has_tcr2(vcpu->kvm)) > > + write_sysreg_el1(0, SYS_TCR2); > > [Severity: Medium] > Does hardware SYS_TCR2 still retain unmasked PIE, POE, and E0POE bits in > __kvm_at_s1e2() and on the !mmu_cs path of __kvm_at_s1e01_fast() when > kvm_has_tcr2(vcpu->kvm) is true? > Yep. Some bits are missing. I'll need to update this one. Also sorry for sending patch 2/2 before patch 1/2. I fat fingered that. regards, dan carpenter